From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 8c81818673a 6/7: Tune volatile in read_char Date: Mon, 19 Aug 2024 19:15:56 +0300 Message-ID: <86y14swksj.fsf@gnu.org> References: <172386820621.30556.15409337288904485218@vcs2.savannah.gnu.org> <20240817041648.A6687C2BC66@vcs2.savannah.gnu.org> <87f24fac-aa71-499f-a398-2bad70a0ca42@cs.ucla.edu> <8634n0y2th.fsf@gnu.org> <87plq4cyuj.fsf@protonmail.com> <861q2ky0tg.fsf@gnu.org> <87le0scxig.fsf@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16243"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acorallo@gnu.org, eggert@cs.ucla.edu, emacs-devel@gnu.org, stefankangas@gmail.com To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 19 18:17:05 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sg544-00044s-V0 for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Aug 2024 18:17:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sg53N-0008Pu-DX; Mon, 19 Aug 2024 12:16:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sg53L-0008HN-4y for emacs-devel@gnu.org; Mon, 19 Aug 2024 12:16:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sg53J-00087N-Nq; Mon, 19 Aug 2024 12:16:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tbaNf1/493dBe1gKtxgwziCjHqyM+UyEBB35nFtBtzA=; b=g0MzFba+LaQ/ dGUexhixQmw40JGjINyC/sU8RQT45pn4Ycwf/uP8iOtnIe1txFjHHq9zmjvqLQyOKNB061mHul4c5 jggaj6P+IZ49tJHfMfyIBsr3AJuy/z66AJ+FG3PBgyBAQPv84b73/pAjMi2kPa/mKYjwUUoQ/NRRM tNjQEi/R8psRLu/7UAr2gZhPy+yMomaP1OE9w7aNsApaLgvm/0mzl3lPjxhh1na52sbiGRiZUb2RF xIODekw4RadzJI99uZkr0fYYqitJDfZN1DlPXAgBp/CJoOUzen/LfAPLdSbSU6SG+bUbLXi7IcmuW rA9+PK0PxuVYX2gFbgMMsA==; In-Reply-To: <87le0scxig.fsf@protonmail.com> (message from Pip Cet on Mon, 19 Aug 2024 16:01:31 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322936 Archived-At: > Date: Mon, 19 Aug 2024 16:01:31 +0000 > From: Pip Cet > Cc: acorallo@gnu.org, eggert@cs.ucla.edu, emacs-devel@gnu.org, stefankangas@gmail.com > > "Eli Zaretskii" writes: > > > In any case, this is not what this thread is about, so let's not mix > > together unrelated issues. > > This thread is about how to deal with automatic variables in > setjmp()-calling functions No, it's about that particular part of what Paul installed. > either duplicating them into a 'c_volatile' > / 'c' pair, as Paul's patch did, or keeping a single volatile > variable. I think "let's make all of them volatile" is an obvious > simplification of that idea. Why not simply undo that single patch, and be done?