From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems Date: Thu, 05 Sep 2024 17:02:13 +0300 Message-ID: <86y1462o7u.fsf@gnu.org> References: <87le083m1s.fsf@ledu-giraud.fr> <877cbqjt03.fsf@posteo.net> <87h6auw6sj.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9013"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73004@debbugs.gnu.org, philipk@posteo.net To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 05 16:10:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smDBX-0002AL-Dr for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Sep 2024 16:10:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smDBO-0008QB-1c; Thu, 05 Sep 2024 10:09:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smDBN-0008Pr-4u for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:09:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smDBM-0007Bf-Qx for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:09:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=RVuCxOftDC3gEeYAe7PMS2Ag2QWJHAu5SXcdlfMGMYw=; b=gpZRXBu9zOkAJPR1KdqCxu1FRjNP8gGt8VZJoIE2vbgvzf1VP9KUIsBiTKRvXCbSKsRYYxkQiXEjhVr9V0fnvb5zncSBy81n9TAC88oHViS9ziVW8t804MDl0Oz2qCUQ5FfgC2F3J/0gxlwfGPH5tIHScBUOwz/qXeHMnvejJdOu9O0GpKRTHs+INr/8x3lpdK5DG+1XBuJCNL6TRBoA9+vk/jGpXg3n1Kb8OQ9x/TYtg3ic5uPCJeYdpHvjIMohycCHz3Jov2BPRiW4wtUDlt+x8nfQ9XeBdCG6Nk0012R8m2UrdUZGaVqZiF9TNuTZIwqcD6Hv5KQcpx31cJQeCw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smDCP-0004Wr-SM for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Sep 2024 14:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73004 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73004-submit@debbugs.gnu.org id=B73004.172554541017259 (code B ref 73004); Thu, 05 Sep 2024 14:11:01 +0000 Original-Received: (at 73004) by debbugs.gnu.org; 5 Sep 2024 14:10:10 +0000 Original-Received: from localhost ([127.0.0.1]:37735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smDBZ-0004UG-OK for submit@debbugs.gnu.org; Thu, 05 Sep 2024 10:10:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smD8H-0004J3-0M for 73004@debbugs.gnu.org; Thu, 05 Sep 2024 10:06:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smD3w-0005m4-Tu; Thu, 05 Sep 2024 10:02:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RVuCxOftDC3gEeYAe7PMS2Ag2QWJHAu5SXcdlfMGMYw=; b=Y0ad9H/kkXE3 6PQ8DL6v6eb/AWjL8MdtToOz6lu/pEx9acSagySYjyQeym2vi2U1WIIdWWMae7JlEVrryOnRD6bFP fKlagd0Sj8RfSkUQxv7wSJHZ86GFMBCVgT3gttIey8TlqL0eCvvCzj7jYwM+2i4iQtbCFGCguI1uW xLxOVh8PGmsd58T4lgSxKODdWeAECL+GaC/DFXsMduYBtN4IYVsjNcD3tJvOXDucoP2Zse9EtCNS9 tODoDbiP838Z5HlP39XMROA0PYaxyUGxMuuw99HmZhGNT/H5ECW314AUncYkjin8FDRAi9MqiJCk5 eSnmujaZo0O5bF/dNcGgHg==; In-Reply-To: <87h6auw6sj.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291257 Archived-At: > Cc: 73004@debbugs.gnu.org > Date: Thu, 05 Sep 2024 15:48:12 +0200 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > And is xdg-open reliably available on BSD systems, so that we don't > > generate an opaque error message if that is not the case? > > I think it would work whether xdg-open is install or not because > `shell-command-guess-open' is defined by testing the presence of > xdg-open. So if xdg-open is not installed, `command' in the code above > will be nil and nothing will happen. Then why do we need to condition this by system-type at all?