all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ken Mankoff <km@kenmankoff.com>
Cc: 73218@debbugs.gnu.org
Subject: bug#73218: [PATCH] Fix Fortran indent below do_not_a_loop=42
Date: Fri, 13 Sep 2024 09:16:05 +0300	[thread overview]
Message-ID: <86y13wjcyi.fsf@gnu.org> (raw)
In-Reply-To: <87o74semoz.fsf@kenmankoff.com> (message from Ken Mankoff on Thu,  12 Sep 2024 11:44:44 -0700)

> From: Ken Mankoff <km@kenmankoff.com>
> Date: Thu, 12 Sep 2024 11:44:44 -0700
> 
> Following up from https://lists.gnu.org/archive/html/emacs-devel/2024-08/msg00904.html I'm submitting a patch to fix Fortran indentation due to an overly aggressive match for do loops.

Thanks.

> --- a/lisp/progmodes/fortran.el
> +++ b/lisp/progmodes/fortran.el
> @@ -1631,7 +1631,7 @@ fortran-calculate-indent
>                 (setq icol (+ icol fortran-if-indent)))
>                ((looking-at "where[ \t]*(.*)[ \t]*\n")
>                 (setq icol (+ icol fortran-if-indent)))
> -              ((looking-at "do\\b")
> +              ((looking-at "do[\\ |0-9]+.*=[\\ a-z0-9_]*,[\\ a-z0-9_]*")

What do you intend with the likes of "[\\ |0-9]+" ?  Is this a
character alternative, or is that an alternative of matches?  If the
former, there's no need to escape a backslash, but then why is '|'
there?

IOW, can you please describe in plain English what did you intend this
regexp to match?

Thanks.





  reply	other threads:[~2024-09-13  6:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 18:44 bug#73218: [PATCH] Fix Fortran indent below do_not_a_loop=42 Ken Mankoff
2024-09-13  6:16 ` Eli Zaretskii [this message]
2024-09-13 15:44   ` Ken Mankoff
2024-09-14 11:15     ` Eli Zaretskii
2024-09-14 14:09       ` Ken Mankoff
2024-09-14 14:20         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y13wjcyi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=73218@debbugs.gnu.org \
    --cc=km@kenmankoff.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.