From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Thu, 21 Nov 2024 21:56:51 +0200 Message-ID: <86y11cnyws.fsf@gnu.org> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> <86ikskvie0.fsf@gnu.org> <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> <8634jov5ir.fsf@gnu.org> <86serntf0h.fsf@gnu.org> <86h680rhxr.fsf@gnu.org> <87h680fotv.fsf@mail.linkov.net> <864j40pfbw.fsf@gnu.org> <87bjy8e5qc.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2116"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 74361@debbugs.gnu.org, rudalics@gmx.at To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 21 20:58:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEDJf-0000Rt-Cn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Nov 2024 20:58:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEDJU-0000cQ-Ja; Thu, 21 Nov 2024 14:58:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEDJS-0000c5-UF for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2024 14:58:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEDJS-0000Mq-Lc for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2024 14:58:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=q65bvYe64pvNBOEzkRGO92wWvEwI7R6uuQdxBui5Gvk=; b=FsXKQ3NOZzgV+k285F07P8VF3EGJEJNpk5QNDB0YcuWGilSz44HyR3fWBhxgyXxj8SUVN7KlZ8LSXiF4YeBfBIUirk8uWQNG8RopolcnhCVlHbD2fS8Au9pbnRrg6Z0liltHPsRp7zyLk9gWTq+8Iu2MfX8Zq9w+DX6dtmyBsXxQcExMh5w5FymBT8DZkZsL0jjS2Obq0bts3K34nm5frZzLLtEsYdsro2xXpMmNcCHhV16Og8vb6yZH7ac1biw/1dh+clIRcBuoyzNq+QprCXIcXHSv246SZLrin74aU4ztwC7T3a1GXTP4ZHxIcNxExgVbsRweryzVEt2uhCzSRw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEDJS-00045b-GR for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2024 14:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2024 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173221902415645 (code B ref 74361); Thu, 21 Nov 2024 19:58:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 21 Nov 2024 19:57:04 +0000 Original-Received: from localhost ([127.0.0.1]:51838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEDIV-00044G-Ny for submit@debbugs.gnu.org; Thu, 21 Nov 2024 14:57:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEDIT-00043k-IQ for 74361@debbugs.gnu.org; Thu, 21 Nov 2024 14:57:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEDIM-0000KP-ME; Thu, 21 Nov 2024 14:56:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=q65bvYe64pvNBOEzkRGO92wWvEwI7R6uuQdxBui5Gvk=; b=nKZzTtTlxuck nHjvgvHgLrjaaHzPUJx484jrPbcyaXHVC6gN3GOhChsDMhCemq9lz0kwjSrSz/qEJPtMSqvHonY7B c98yAeeq/TXn+xpnn7uJJZCerillEFntc9QY36mh+cFh/NkiOxsjUL0E8gEYz5Fn+5nbwY/6F7bNQ +9qdxt43FIOAcfVWT5swFbJwYexk8Qm9rAHODcAZT4CjF2pTtTdeowoFwNIKu2ZWY9OwBd/YGlMcp 5dHXDh9Cc17vRsqiyh7Gl0iG4ouiZsSEs0r1L3TCatK/D/K9vZ7g/2kUF7k5wzEXKcJ+1nWh5scs0 Eq9GFFX8ga+8o7gQzpYBig==; In-Reply-To: <87bjy8e5qc.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 21 Nov 2024 21:39:39 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295752 Archived-At: > From: Juri Linkov > Cc: dmitry@gutov.dev, rudalics@gmx.at, 74361@debbugs.gnu.org > Date: Thu, 21 Nov 2024 21:39:39 +0200 > > >> > If someone explains to me in small words how this works in comint (and > >> > other modes which provide a similar category symbol), I will see about > >> > improving and clarifying the docs. > >> > >> '(category . comint)' is used in 'display-comint-buffer-action' > >> that is marked obsolete. So for Emacs 31 its defcustom could be > >> downgraded to a simple defvar, and moved to comint.el, and maybe > >> also autoloaded when it's used by modes independent from comint.el. > > > > But nothing in comint.el uses this category when calling > > display-buffer, AFAICS. So how can users use this category to > > customize the way comint buffers are displayed? > > This category is used by modes that inherit from comint-mode, e.g.: > > cmuscheme.el: > (define-derived-mode inferior-scheme-mode comint-mode "Inferior Scheme" > ... > (pop-to-buffer "*scheme*" display-comint-buffer-action) > > inf-lisp.el: > (define-derived-mode inferior-lisp-mode comint-mode "Inferior Lisp" > ... > (pop-to-buffer "*inferior-lisp*" display-comint-buffer-action) > > shell.el: > (define-derived-mode shell-mode comint-mode "Shell" > ... > (pop-to-buffer buffer display-comint-buffer-action) Those are not the categories, those are the deprecated user options for which the categories are supposed to be a replacement we recommend: (make-obsolete-variable 'display-comint-buffer-action "use a `(category . comint)' condition in `display-buffer-alist'." "30.1") So if some user wants to take our advice and modernize his/her customizations to use '(category . comint)' instead of display-comint-buffer-action, the customization will stop working for him/her when we remove those obsolete options in some future Emacs version. Right? Or what am I missing?