Re: master a4014c058b5 1/2: Add new `header-line-active' and `header-line-inactive' faces

Re: master a4014c058b5 1/2: Add new `header-line-active' and `header-line-inactive' faces

[Eshel Yaron]

Hi,

Eli Zaretskii <eliz@gnu.org> writes:

> branch: master
> commit a4014c058b547d4f9c8c61c6737c85c2636fdb34
> Author: Trevor Murphy <trevor.m.murphy@gmail.com>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
>     Add new `header-line-active' and `header-line-inactive' faces
>     
>     This is all intended to parallel the 'mode-line-active' and
>     'mode-line-inactive' distinction.
[...]

This seems to introduce a regression, consider the following recipe:

1. emacs -Q
2. In the scratch buffer, evaluate:
   (setq header-line-format "foobar")
   (face-remap-add-relative 'header-line 'highlight)
3. Type C-x C-M-= or something similar to force updating the header
   line.  The header line in the scratch buffer now shows "foobar" and
   uses the highlight face, as expected
4. Type C-x 4 b new RET to switch to another buffer in another window
5. In the new buffer evaluate (setq header-line-format "foobar")
6. Observe that the header line in the new buffer is also using the
   highlight face.  That's unexpected!
7. Type C-x C-M-= while the new buffer is current
8. Observe that the header lines in both windows no longer have the
   highlight face.  That's unexpected!

Before, remapping the header-line face with face-remap-add-relative
would only affect the current buffer, as expected.  Now it seems like
the face remapping "leaks" between buffers/windows somehow...


Best regards,

Eshel

Re: master a4014c058b5 1/2: Add new `header-line-active' and `header-line-inactive' faces

[Eli Zaretskii]

> From: Eshel Yaron <me@eshelyaron.com>
> Cc: Trevor Murphy <trevor.m.murphy@gmail.com>
> Date: Wed, 04 Dec 2024 10:47:18 +0100
> 
> >     Add new `header-line-active' and `header-line-inactive' faces
> >     
> >     This is all intended to parallel the 'mode-line-active' and
> >     'mode-line-inactive' distinction.
> [...]
> 
> This seems to introduce a regression, consider the following recipe:
> 
> 1. emacs -Q
> 2. In the scratch buffer, evaluate:
>    (setq header-line-format "foobar")
>    (face-remap-add-relative 'header-line 'highlight)
> 3. Type C-x C-M-= or something similar to force updating the header
>    line.  The header line in the scratch buffer now shows "foobar" and
>    uses the highlight face, as expected
> 4. Type C-x 4 b new RET to switch to another buffer in another window
> 5. In the new buffer evaluate (setq header-line-format "foobar")
> 6. Observe that the header line in the new buffer is also using the
>    highlight face.  That's unexpected!
> 7. Type C-x C-M-= while the new buffer is current
> 8. Observe that the header lines in both windows no longer have the
>    highlight face.  That's unexpected!
> 
> Before, remapping the header-line face with face-remap-add-relative
> would only affect the current buffer, as expected.  Now it seems like
> the face remapping "leaks" between buffers/windows somehow...

Thanks, this is being discussed in bug#73862.  I will respond there.

Please in the future report bugs to the bug tracker, even if the bug
is in the development version of Emacs.