From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74415: 29.4; mouse-start-end does not respect syntax-table text properties Date: Sat, 04 Jan 2025 12:54:21 +0200 Message-ID: <86y0zqetnm.fsf@gnu.org> References: <86cyilj6ks.fsf@gnu.org> <86mshjcpod.fsf@gnu.org> <86seqzisg2.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15815"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guillaume.brunerie@gmail.com, 74415-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 04 11:55:20 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU1oL-0003zy-W4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jan 2025 11:55:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU1o9-0003Tw-To; Sat, 04 Jan 2025 05:55:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU1o8-0003TH-0z for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 05:55:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU1o7-00083E-8T for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 05:55:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=yuf2zNEpAP0LGSMzcgZPjbSazTYoyMqLS5pmtrFktGA=; b=W0GBK0g5dW8LAusjREGgS94ZgDdH08HQ+iAibgaUYp5/Y85PvVY0Lj7O87dy4rteLFlYHVP7g/qMHNlCvgkiawENOrMhw1J8fNsDqJmvNK6a0MnMzXPAflY/KV4JOAAfZaTJwbOisLDN7pKqMN2UbKXl4zPbOP/oxMO0PTVlEpWEP/NfhtXoGAxr/hDxThNDXiT5aE/VlTI/XVwtfjX3ZCLm8wSJ5of557mSlmOjHe6We3BFmwOhu6awQP+qZraBPi/5+LQi16uJoC3Zvee0ZO9I3y8UMSAmCzfGEw/31DjF/Z5PjObcu81iLDwjzFzWZw5l+jBCeaTQELVABV9t8A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU1o6-0000mO-4J for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 05:55:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 10:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74415 X-GNU-PR-Package: emacs Mail-Followup-To: 74415@debbugs.gnu.org, eliz@gnu.org, guillaume.brunerie@gmail.com Original-Received: via spool by 74415-done@debbugs.gnu.org id=D74415.17359880742943 (code D ref 74415); Sat, 04 Jan 2025 10:55:01 +0000 Original-Received: (at 74415-done) by debbugs.gnu.org; 4 Jan 2025 10:54:34 +0000 Original-Received: from localhost ([127.0.0.1]:53502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU1nd-0000lP-Id for submit@debbugs.gnu.org; Sat, 04 Jan 2025 05:54:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34444) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU1nb-0000lB-LA for 74415-done@debbugs.gnu.org; Sat, 04 Jan 2025 05:54:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU1nW-00081G-27; Sat, 04 Jan 2025 05:54:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yuf2zNEpAP0LGSMzcgZPjbSazTYoyMqLS5pmtrFktGA=; b=g6Nv0OALpr79 JxVdHO9o4SirxsR4OZONeud0huCojnIxizFJgwjF8fNJbMBsxV0TdxdDpoJjqKJw6U8B3fxlr5oJ5 jg1Fgvs+KAA1l9tBcuZIa8hRgY09MQ6uq5P6peYhqFlGZHSXH2T4tPGwBn1pzWEgQb56nsKT5w/VI /JnStKkGYb5Kt8JUnxDRj8sgEe0AViMyIqeVv3oHYUQJa7NQKLYsY1rq+3VUgKY6eKpoeX3exEPMs bzhqLjaoBTan8Lh1G+EK5ZJVmzzn8YL0PVBrxQsJV75igvU8n+dQ2UNZQOcOphkNsgzeZOl7ytvy4 70p+IhWeMXGZqcyKZZQaTA==; In-Reply-To: (message from Stefan Monnier on Fri, 13 Dec 2024 12:05:55 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298356 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , 74415@debbugs.gnu.org > Date: Fri, 13 Dec 2024 12:05:55 -0500 > > > No, it was not dead code before, but changing the outer condition > > makes it impossible for both the outer condition and the inner > > condition to be true at the same time. > > The current code is the following (inside a cond) > > > > ((and (= mode 1) > > (= start end) > > (char-after start) > > (= (char-syntax (char-after start)) ?\()) > > (if (/= (syntax-class (syntax-after start)) 4) ; raw syntax code for ?\( > > ;; This happens in CC Mode when unbalanced parens in CPP > > ;; constructs are given punctuation syntax with > > ;; syntax-table text properties. (2016-02-21). > > (signal 'scan-error (list "Containing expression ends prematurely" > > start start)) > > (list start > > (save-excursion > > (goto-char start) > > (forward-sexp 1) > > (point))))) > > I have the strong impression that this reflects the fact that the > if+signal was a workaround which we're now replacing with an actual fix. Evidently. So I've now installed my changes on the master branch, after removing the unneeded code which signals an error, and I'm therefore closing this bug.