From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Newsgroups: gmane.emacs.devel Subject: Re: trunk r117396: Do not allow out-of-range character position in Fcompare_strings. Date: Wed, 25 Jun 2014 16:22:03 +0300 Message-ID: <86wqc5kttw.fsf@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1403702565 5084 80.91.229.3 (25 Jun 2014 13:22:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Jun 2014 13:22:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 25 15:22:39 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wzn9i-0008LZ-1c for ged-emacs-devel@m.gmane.org; Wed, 25 Jun 2014 15:22:30 +0200 Original-Received: from localhost ([::1]:37706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzn9h-00008f-HG for ged-emacs-devel@m.gmane.org; Wed, 25 Jun 2014 09:22:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzn9a-00008U-8z for emacs-devel@gnu.org; Wed, 25 Jun 2014 09:22:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wzn9V-0005XT-G0 for emacs-devel@gnu.org; Wed, 25 Jun 2014 09:22:22 -0400 Original-Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]:32908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzn9V-0005XL-9B for emacs-devel@gnu.org; Wed, 25 Jun 2014 09:22:17 -0400 Original-Received: by mail-wg0-f51.google.com with SMTP id x12so1929650wgg.22 for ; Wed, 25 Jun 2014 06:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=XiRBs+KafWgUoBqhYtjXHbMKf3MmSYlY68vGctRsyb8=; b=I5Ndk39ogwVVXUg0R2l/BDNLJjllJJrmn8P8h6lKlEut4GSXntj7IzB8VhzeOG0f2D 3fC+iWtudCzAeDEDz4eVExt07ZqqpMjtp+co/UIbc6YdjMeqFk7WAC8nygg/eZeQbfjG s9DwhsME0mm8MPAXZeEKlhrY9x06NSDQMw9JMwYVsMadSim8ATlQDsc5P3mdOyVsoXwV i65HNKw82bpYgNKnnu4pz34wYeOtch95BK8alm9ig2gT3TGqQ7OKfpLKbYwl5xxHNQ+W ENmzk9p4xMAnCycxSdDATOHhvfEkwcLVaxhmqRSc+8wfQd0dWZVLlgUmQMuYniLbbDA7 3euw== X-Received: by 10.194.86.225 with SMTP id s1mr9784085wjz.21.1403702530591; Wed, 25 Jun 2014 06:22:10 -0700 (PDT) Original-Received: from axl (62-120-106.netrun.cytanet.com.cy. [62.228.120.106]) by mx.google.com with ESMTPSA id cz8sm7495511wjc.11.2014.06.25.06.22.08 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 25 Jun 2014 06:22:09 -0700 (PDT) In-Reply-To: (Dmitry Antipov's message of "Wed, 25 Jun 2014 10:37:25 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.91 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172701 Archived-At: Dmitry Antipov writes: > ------------------------------------------------------------ > revno: 117396 > revision-id: dmantipov@yandex.ru-20140625103651-k76n6ekn8asbgf5p > parent: rgm@gnu.org-20140625101741-09kj8husqtljm4u0 > committer: Dmitry Antipov > branch nick: trunk > timestamp: Wed 2014-06-25 14:36:51 +0400 > message: > Do not allow out-of-range character position in Fcompare_strings. > * src/fns.c (validate_subarray): Add prototype. > (Fcompare_substring): Use validate_subarray to check ranges. > Adjust comment to mention that the semantics was changed. Also see > http://lists.gnu.org/archive/html/emacs-devel/2014-06/msg00447.html. IIUC, this small discussion ended with "it's too late to fix". Why did you make the change, then? And if it's okay to change the semantics, why not change it the other way, relaxing `substring' requirements? There was a thread not too long ago requesting that.