all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Brinkhoff <lars@nocrew.org>
To: emacs-devel@gnu.org
Subject: Re: User-defined record types, v2
Date: Sun, 19 Mar 2017 10:17:35 +0100	[thread overview]
Message-ID: <86wpblsk0g.fsf@molnjunk.nocrew.org> (raw)
In-Reply-To: jwvefxufcyz.fsf-monnier+gmane.emacs.devel@gnu.org

Stefan Monnier wrote:
>> I initially added this function to check everywhere that the first
>> slot is a valid defstruct type name.  But then Stefan Monnier added
>> support for EIEIO instances and made the first slot be a class
>> object.
>
> But I'm not even sure we should enforce this in the `record` and
> `make-record` primitives.  After all, it's not needed for safety.  And
> since we allow (aset <obj> 0 <foo>) we can circumvent this check
> anyway.

Not quite.  `aset' does the check too.

Also, I thought about disallowing the built-in types.  I imagine some
code would rightly get confused if it saw `integer' for anything else
than integers.  But then, so much else in Emacs depends on people doing
sensible things, so maybe no check is needed at all.

If we come up with a need for a check, we know where to add it.  If not,
I can just delete the unused code.




  reply	other threads:[~2017-03-19  9:17 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-18 17:04 User-defined record types, v2 Lars Brinkhoff
2017-03-18 17:05 ` Lars Brinkhoff
2017-03-18 17:13   ` Lars Brinkhoff
2017-03-18 17:17     ` Lars Brinkhoff
2017-03-18 17:21       ` Lars Brinkhoff
2017-03-18 17:35         ` Eli Zaretskii
2017-03-18 19:33           ` Lars Brinkhoff
2017-03-18 22:24             ` Stefan Monnier
2017-03-19  9:17               ` Lars Brinkhoff [this message]
2017-03-19 12:50                 ` Stefan Monnier
2017-03-19 14:51                   ` Eli Zaretskii
2017-03-18 17:29   ` Eli Zaretskii
2017-03-19 10:28 ` Lars Brinkhoff
2017-03-19 12:51   ` Stefan Monnier
2017-03-21  9:55 ` Lars Brinkhoff
2017-03-21 11:53   ` Stefan Monnier
2017-03-22 21:15   ` Stefan Monnier
2017-03-23  6:53     ` Lars Brinkhoff
2017-03-23  7:02       ` Lars Brinkhoff
2017-03-23  7:34         ` Lars Brinkhoff
2017-03-23 19:47         ` Stefan Monnier
2017-03-24 10:15           ` Lars Brinkhoff
2017-03-24 18:17             ` Stefan Monnier
2017-03-24 20:38               ` Lars Brinkhoff
2017-03-29 12:46             ` Lars Brinkhoff
2017-03-30 12:59               ` Stefan Monnier
2017-03-30 14:57                 ` Lars Brinkhoff
2017-03-30 15:07                   ` Stefan Monnier
2017-03-30 18:10                     ` Eli Zaretskii
2017-03-22  7:58 ` Lars Brinkhoff
2017-03-22  8:46   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wpblsk0g.fsf@molnjunk.nocrew.org \
    --to=lars@nocrew.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.