From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums
Date: Sat, 27 Oct 2018 13:15:54 +0100 [thread overview]
Message-ID: <86woq360w5.fsf@gmail.com> (raw)
In-Reply-To: 83pnvwo7i3.fsf@gnu.org
On Fri 26 Oct 2018, Eli Zaretskii wrote:
>> From: Stefan Monnier <monnier@iro.umontreal.ca>
>> Cc: emacs-devel@gnu.org
>> Date: Fri, 26 Oct 2018 14:23:26 -0400
>>
>> >> Would you feel the same if `pcase` always used `equal` and the
>> >> optimization to `eql` were performed in the byte-compiler instead?
>> > I don't know, and it's not really relevant, is it?
>>
>> It is: the use of `eq` or `eql` here is an optimization which pcase
>> performs only because the compiler doesn't do it.
>
> I disagree. We describe our code, not what the compiler produces out
> of it.
Documentation should be describing the fixed semantics of the interface,
not the details of the underlying implementation, nor aspects of the
interface that expose details of the current implementation.
AndyM
prev parent reply other threads:[~2018-10-27 12:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 9:03 [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums Eli Zaretskii
2018-10-26 14:17 ` Stefan Monnier
2018-10-26 15:02 ` Eli Zaretskii
2018-10-26 16:04 ` Stefan Monnier
2018-10-26 17:33 ` Eli Zaretskii
2018-10-26 18:23 ` Stefan Monnier
2018-10-26 19:00 ` Paul Eggert
2018-10-26 19:37 ` Stefan Monnier
2018-10-26 19:03 ` Eli Zaretskii
2018-10-26 19:37 ` Stefan Monnier
2018-10-27 12:15 ` Andy Moreton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86woq360w5.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.