From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: autoload cl-defstruct constructor? Date: Mon, 09 Sep 2019 12:35:43 -0700 Message-ID: <86woeh6z5c.fsf@stephe-leake.org> References: <86k1anriz5.fsf@stephe-leake.org> <86ef0u8geu.fsf@stephe-leake.org> <86a7bh83l2.fsf@stephe-leake.org> <861rwp8err.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="151590"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 09 21:35:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i7PS9-000dFP-QU for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 21:35:57 +0200 Original-Received: from localhost ([::1]:60286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7PS8-0000SN-38 for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 15:35:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47463) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7PS1-0000RW-Ue for emacs-devel@gnu.org; Mon, 09 Sep 2019 15:35:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7PS0-0005AK-97 for emacs-devel@gnu.org; Mon, 09 Sep 2019 15:35:49 -0400 Original-Received: from gateway31.websitewelcome.com ([192.185.144.80]:21391) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7PS0-00059j-4n for emacs-devel@gnu.org; Mon, 09 Sep 2019 15:35:48 -0400 Original-Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id AEA395DC9D for ; Mon, 9 Sep 2019 14:35:46 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id 7PRyiBtCl4FKp7PRyiDi7W; Mon, 09 Sep 2019 14:35:46 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=49vEVsnRF8D9C9JAqaCiqiFF1bQ1NDJzwBkWW3aoB1A=; b=jLsofMSatCWvJqyLm+7wnAr7W UYCzpkaBFdXa0urr3T2GiCiRvOxU2L9rnbTaKjc8Z9EjVmqdG4TQfnV6MuPA5LD2+scPCoFdTpqaQ VT/xnlNaXpp3W/B7vPM1AbiqycF8/+rE9O06KfpRUoncXUzYKruIeyqshU3WANxvIHme15vcNGXLl CjoDnoHon5UttO1zs540IQsPCDlzl8bnpW1s5dcMoCiX2iK2j19xQCV+RPjnmjxHxQYU7sF2jkr30 x+ucyyXbOp6APxV5Bo8vPvRatC+iXra3QfmLSLmW30tVrSntWWM88Wo9UahG/pQEgFPUa2CNLa/id k3dvVFDcg==; Original-Received: from [76.77.182.20] (port=51685 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i7PRy-0005PW-2x for emacs-devel@gnu.org; Mon, 09 Sep 2019 13:35:46 -0600 In-Reply-To: <861rwp8err.fsf@stephe-leake.org> (Stephen Leake's message of "Mon, 09 Sep 2019 12:12:56 -0700") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1i7PRy-0005PW-2x X-Source-Sender: (Takver4) [76.77.182.20]:51685 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 2 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 192.185.144.80 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239965 Archived-At: Stephen Leake writes: > Now I have to figure out the minimum workaround for emacs 25, 26 > compatibility. This is a problem. The first thing I have to do is disable the autoload on the cl-defstruct, because leaving it in makes the autoload file fail due to declaration order violations. I don't see a way to do that short of actually editing the file. The autoload cookie is handled in autoload--print-cookie-text; it does a simple '(search-forward generate-autoload-cookie)', so surrounding the cookie with '(if (< emacs-major-version 27)' will not have the desired effect. The only workaround I can see for the ELPA package is to create a new package ada-mode-1 that requires emacs < 27, and bump the emacs require for ada-mode to 27. Then I can use sed or something to edit the source files for the ada-mode-1 package. Of course, ELPA doesn't support an upper limit on a require version. Another way to handle this and similar issues in the future is to add a "preprocess files" step to the package.el build process, which is normally null. -- -- Stephe