From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Derek Zhou via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#40665: 28.0.50; tls hang on local ssl Date: Fri, 24 Apr 2020 14:23:50 +0000 (UTC) Message-ID: <86wo65arnu.fsf@mail.3qin.us> References: <86wo6fo78r.fsf@mail.3qin.us> <86eeslecnf.fsf@mail.3qin.us> <86blnnebh3.fsf@mail.3qin.us> <86zhb5hecx.fsf@mail.3qin.us> <86eeshpqdb.fsf@mail.3qin.us> <86zhb5q7sw.fsf@mail.3qin.us> <86y2qorj76.fsf@mail.3qin.us> <86368w1tge.fsf@mail.3qin.us> <864ktcfpm5.fsf@mail.3qin.us> <86368wfp6d.fsf@mail.3qin.us> <86y2qniu5m.fsf@mail.3qin.us> <86wo67im9w.fsf@mail.3qin.us> <86y2qnaqnv.fsf@mail.3qin.us> Reply-To: Derek Zhou Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="37036"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.2.0; emacs 27.0.91 Cc: 40665@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 24 16:24:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRzFS-0009Tx-Sz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Apr 2020 16:24:11 +0200 Original-Received: from localhost ([::1]:39390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRzFR-0001Jt-R3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Apr 2020 10:24:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57134) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRzFK-0001Jb-IC for bug-gnu-emacs@gnu.org; Fri, 24 Apr 2020 10:24:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRzFK-0001pw-3S for bug-gnu-emacs@gnu.org; Fri, 24 Apr 2020 10:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRzFJ-0001pr-OX for bug-gnu-emacs@gnu.org; Fri, 24 Apr 2020 10:24:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jRzFJ-0002BW-JC for bug-gnu-emacs@gnu.org; Fri, 24 Apr 2020 10:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Derek Zhou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Apr 2020 14:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40665 X-GNU-PR-Package: emacs Original-Received: via spool by 40665-submit@debbugs.gnu.org id=B40665.15877382378386 (code B ref 40665); Fri, 24 Apr 2020 14:24:01 +0000 Original-Received: (at 40665) by debbugs.gnu.org; 24 Apr 2020 14:23:57 +0000 Original-Received: from localhost ([127.0.0.1]:57664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRzFF-0002BC-8m for submit@debbugs.gnu.org; Fri, 24 Apr 2020 10:23:57 -0400 Original-Received: from xtrwkkxd.outbound-mail.sendgrid.net ([167.89.17.173]:15972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRzFD-0002Ax-Rp for 40665@debbugs.gnu.org; Fri, 24 Apr 2020 10:23:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=3qin.us; h=references:from:subject:in-reply-to:mime-version:to:cc:content-type: content-transfer-encoding; s=s1; bh=k10Y20uXyIvcH3N9in8YToMYDf19DLUiORezltCjMuk=; b=utdMR4V59SH2OXF0A9XSIOxR5CbAR3Di0Be10SPr6vnemQ9qGxKFWUiwssIR4rtAL735 5SbLPlgPS3Cm+PEZjDp1WndY/SE8RAtcfwm2BStWl925JKnHWXXBjE+r2YflNTrIGNbhTf l2lt0sRbymi5u5DkyAhCmfQY0V5Rrsb7E= Original-Received: by filterdrecv-p3mdw1-6dbfd75bfd-h68rz with SMTP id filterdrecv-p3mdw1-6dbfd75bfd-h68rz-18-5EA2F676-20 2020-04-24 14:23:50.413874002 +0000 UTC m=+2553383.526141803 Original-Received: from mail.3qin.us (unknown) by ismtpd0005p1sjc2.sendgrid.net (SG) with ESMTP id MxsruELuRf67PqFn3gflqQ Fri, 24 Apr 2020 14:23:50.064 +0000 (UTC) Original-Received: from derek by mail.3qin.us with local (Exim 4.92) (envelope-from ) id 1jRzF7-0000kW-Ae; Fri, 24 Apr 2020 10:23:49 -0400 In-reply-to: <86y2qnaqnv.fsf@mail.3qin.us> X-SG-EID: nTv1epxWypfl0GRwygk8G5JZcpWJeBCcUM8ly3qzpbbVyfDgYog/9eXX7sL09UAmbQROjJaCvVHlziHUMIHGn47nMIyALtXsXoDHxa2u+Gjgt8zE3Zo1otp88seBhLBf56oWn6j2ALqo2IwFAsE79HXXYUp54Y90TuQ7nCcDCv3MLBLJNbfu5phlZZbPKBP5ueXBg1khSUhzLsLJGVsR6WezxRmLlPoVlpfnjCXvkHbKHF/HvhyC2cslRgG85pcT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178925 Archived-At: Derek Zhou writes: > Robert Pluim writes: > >> OK, that does make sense, and might even be more correct, but it=CA=BCs = a >> bigger change. You'll need more than just me to agree with it. >> > Patch reworked: > > * before the select, check every interesting gnutls stream for > available data in the buffer > * if some of them hit, and either there is no wait_proc or the > wait_proc is one of the gnutls streams with new data, set the select > timeout to 0 > * after the select, merge the gnutls buffer status into the select > returns > > The patch is not much longer than before, still a net reduction of code > lines. I've done some light testing and haven't found any problem.=20 Robert, did you get a chance to read and test this patch? Derek