all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 52491@debbugs.gnu.org
Subject: bug#52491: 28.0.90; Regression in window deletion with minibuffer
Date: Sun, 19 Dec 2021 19:14:08 +0200	[thread overview]
Message-ID: <86wnk0frfj.fsf@mail.linkov.net> (raw)
In-Reply-To: <9c2cbe85-b1a0-f147-69c8-0f26ab2e7c4d@gmx.at> (martin rudalics's message of "Sun, 19 Dec 2021 11:14:32 +0100")

>> Maybe it would be possible to change the default behavior of delete-window
>> to do what it did in Emacs 27?  But honestly, I don't understand how
>> this old code managed to select the minibuffer after deleting the
>> completions buffer and why its behavior differs after it was moved to Lisp:
>>
>> -	  /* Now look whether `get-mru-window' gets us something.  */
>> -	  mru_window = call1 (Qget_mru_window, frame);
>> -	  if (WINDOW_LIVE_P (mru_window)
>> -	      && EQ (XWINDOW (mru_window)->frame, frame))
>> -	    new_selected_window = mru_window;
>
> I doubt that anything has changed here - the Emacs 27 code didn't select
> the minibuffer window either.  What has changed, however, is the value
> of the 'quit-restore' parameter of the *Completions* window.  With Emacs
> 27 it was a a quadruple whose third element was the minibuffer window
> which subsequently got selected.  With Emacs 28 it is nil.

I checked that the value is the same in 27 and 28.  But while comparing
quit-restore-window in 27 and 28 indeed there are many differences.

In 27, quit-restore-window calls window--delete, and then later does
`(select-window (nth 2 quit-restore))'.

But in 28, for the dedicated *Completions* window it calls
window--delete, but doesn't call `(select-window (nth 2 quit-restore))'
afterwards, that is another `cond' branch.





  reply	other threads:[~2021-12-19 17:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 21:08 bug#52491: 28.0.90; Regression in window deletion with minibuffer Juri Linkov
2021-12-16 17:28 ` Juri Linkov
2021-12-16 17:50   ` Eli Zaretskii
2021-12-16 19:02     ` Juri Linkov
2021-12-16 20:05       ` Eli Zaretskii
2021-12-17  8:25         ` Juri Linkov
2021-12-17 12:04           ` Eli Zaretskii
2021-12-18  9:05             ` martin rudalics
2021-12-18 17:20               ` Juri Linkov
2021-12-19 10:14                 ` martin rudalics
2021-12-19 17:14                   ` Juri Linkov [this message]
2021-12-19 18:16                     ` martin rudalics
2021-12-19 18:25                       ` Juri Linkov
2021-12-20  9:18                         ` martin rudalics
2021-12-20 17:29                           ` Eli Zaretskii
2021-12-20 18:08                             ` martin rudalics
2021-12-20 18:18                               ` Eli Zaretskii
2021-12-21  8:05                               ` Juri Linkov
2021-12-21 10:33                                 ` martin rudalics
2021-12-21 19:13                                   ` Juri Linkov
2021-12-22  9:23                                     ` martin rudalics
2021-12-21  8:08                           ` Juri Linkov
2021-12-21 10:34                             ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wnk0frfj.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=52491@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.