From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Date: Thu, 18 May 2023 18:46:28 +0300 Organization: LINKOV.NET Message-ID: <86wn153b43.fsf@mail.linkov.net> References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <861qjgkvui.fsf@mail.linkov.net> <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> <86ilcqnbsp.fsf@mail.linkov.net> <3a021a53-814d-3721-31fb-b77f4087a455@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38245"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 62427@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 18 18:02:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzg5d-0009fN-6J for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 May 2023 18:02:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzg4r-0006sn-2c; Thu, 18 May 2023 12:02:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzg4o-0006rp-JV for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 12:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzg4o-0002tQ-AG for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 12:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzg4o-00075s-5W for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 12:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 May 2023 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs Original-Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168442568427166 (code B ref 62427); Thu, 18 May 2023 16:02:02 +0000 Original-Received: (at 62427) by debbugs.gnu.org; 18 May 2023 16:01:24 +0000 Original-Received: from localhost ([127.0.0.1]:54252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzg4C-000745-5G for submit@debbugs.gnu.org; Thu, 18 May 2023 12:01:24 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:58829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzg49-00073p-2g for 62427@debbugs.gnu.org; Thu, 18 May 2023 12:01:22 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id D854CFF803; Thu, 18 May 2023 16:01:13 +0000 (UTC) In-Reply-To: <3a021a53-814d-3721-31fb-b77f4087a455@gmx.at> (martin rudalics's message of "Thu, 18 May 2023 10:31:13 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261945 Archived-At: >> Would it be possible to update 'minibuf_selected_window' >> with a new window after deleting the original window? > > Not really. We'd change existing behavior that might rely on the fact > that 'minibuffer-selected-window' returns nil once it got deleted. > > Besides, it might not make you happy anyway. With the default of > 'minibuffer-follows-selected-frame', a user may correspond with a > minibuffer window that resides on another frame than that returned by > 'minibuffer-selected-window' and neither minibuf_selected_window nor > Vminibuf_scroll_window may make sense any more in such context. > > Why don't you use 'get-mru-window' on the frame that owns the > 'minibuffer-window' instead of 'minibuffer-selected-window'? Thanks for the idea, this works perfectly: diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 42fc5a23990..0ae7fb44b27 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1339,8 +1340,7 @@ tab-bar-select-tab (ws ;; `window-state-put' fails when called in the minibuffer - (when (minibuffer-selected-window) - (select-window (minibuffer-selected-window))) + (when (minibufferp) (select-window (get-mru-window))) (window-state-put ws nil 'safe))) ;; Select the minibuffer when it was active before switching tabs @@ -1575,8 +1575,7 @@ tab-bar-new-tab-to (when tab-bar-new-tab-choice ;; Handle the case when it's called in the active minibuffer. - (when (minibuffer-selected-window) - (select-window (minibuffer-selected-window))) + (when (minibufferp) (select-window (get-mru-window))) (let ((ignore-window-parameters t) (window--sides-inhibit-check t)) (if (eq tab-bar-new-tab-choice 'clone)