From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#64575: 29.0.92; Help buffers are unnecessarily under Outline mode Date: Thu, 13 Jul 2023 19:39:23 +0300 Organization: LINKOV.NET Message-ID: <86wmz3ix50.fsf@mail.linkov.net> References: <83a5w26yum.fsf@gnu.org> <86a5w17hn4.fsf@mail.linkov.net> <831qhd71cp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38397"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 64575@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 13 18:41:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJzNo-0009u4-IN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jul 2023 18:41:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJzNV-0007Jr-AL; Thu, 13 Jul 2023 12:41:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJzNO-0007JI-Nb for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 12:41:12 -0400 Original-Received: from [2001:470:142:5::43] (helo=debbugs.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJzNH-0003Re-3W for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 12:41:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJzNG-0005Ox-IM for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 12:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 16:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64575 X-GNU-PR-Package: emacs Original-Received: via spool by 64575-submit@debbugs.gnu.org id=B64575.168926641620686 (code B ref 64575); Thu, 13 Jul 2023 16:41:02 +0000 Original-Received: (at 64575) by debbugs.gnu.org; 13 Jul 2023 16:40:16 +0000 Original-Received: from localhost ([127.0.0.1]:40688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJzMW-0005NZ-3i for submit@debbugs.gnu.org; Thu, 13 Jul 2023 12:40:16 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:35841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJzMP-0005NB-7Z for 64575@debbugs.gnu.org; Thu, 13 Jul 2023 12:40:13 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 9227920009; Thu, 13 Jul 2023 16:40:01 +0000 (UTC) In-Reply-To: <831qhd71cp.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 Jul 2023 15:36:54 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265030 Archived-At: >> OTOH, when some Help command will insert a heading line, then it will >> be handled automatically. For example, 'C-h m' (describe-mode) could >> take advantage of outline-minor-mode with heading lines for every >> displayed minor mode. > > If some Help feature can benefit from outline-minor-mode, it should > turn that mode on by itself, not rely on that being set already by > some other code. I tried to enable outline-minor-mode in the output buffer of 'C-h m', and it has some problems: 1. outline-regexp of 'C-h b' is not suitable for 'C-h m', because the output of 'C-h b' is more uniform, but the output of 'C-h m' includes free-form text that causes false positives for the regexp ".*:$". 2. heading lines of 'C-h m' are beginning with a link, so the link faces are copied to the outline indicator. Both these problems could be fixed by adding an asterisk to the beginning of headings in 'C-h m', for example: * Font-Lock minor mode (no indicator): Does this look nice? Or should we try to find a regexp for existing output? >> > The actual functions you use in "C-h f" don't matter; the point is >> > that the Outline minor mode, once set by "C-h b", stays turned on in >> > the *Help* buffers, instead of being reset when not needed. >> >> If you still think it should be disabled everywhere outside of 'C-h b', >> this could be fixed by such patch: > > Thanks, I think this should be installed on master (assuming that it > solves the problem; I didn't have time to try it). I did more testing, and pushed to master.