From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69953: [PATCH] Remove duplicated asserts and checks Date: Sat, 11 May 2024 15:18:32 +0300 Message-ID: <86wmo01qzr.fsf@gnu.org> References: <9378099f-76e1-45b4-8e4d-0f077cb28307@gmail.com> <86o7b5zafb.fsf@gnu.org> <86jzl1r9mt.fsf@gnu.org> <86r0erw6pu.fsf@gnu.org> <86wmo378hj.fsf@gnu.org> <86a5kw3bvq.fsf@gnu.org> <40cfb760-bf82-4a02-bca5-bec81a00e619@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38384"; mail-complaints-to="usenet@ciao.gmane.io" Cc: p.stephani2@gmail.com, dancol@dancol.org, 69953@debbugs.gnu.org To: Sergey Vinokurov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 11 14:21:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s5lj5-0009kj-7W for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 May 2024 14:21:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5lis-0007ab-Cd; Sat, 11 May 2024 08:21:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5lip-0007Z9-NC for bug-gnu-emacs@gnu.org; Sat, 11 May 2024 08:21:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s5lio-0005Ov-Lv for bug-gnu-emacs@gnu.org; Sat, 11 May 2024 08:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s5lin-000692-KM for bug-gnu-emacs@gnu.org; Sat, 11 May 2024 08:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 May 2024 12:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69953 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch wontfix Original-Received: via spool by 69953-submit@debbugs.gnu.org id=B69953.171543005623605 (code B ref 69953); Sat, 11 May 2024 12:21:01 +0000 Original-Received: (at 69953) by debbugs.gnu.org; 11 May 2024 12:20:56 +0000 Original-Received: from localhost ([127.0.0.1]:48067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5lih-00068f-Td for submit@debbugs.gnu.org; Sat, 11 May 2024 08:20:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5lif-00068Z-Ol for 69953@debbugs.gnu.org; Sat, 11 May 2024 08:20:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5lgS-0004yA-Gr; Sat, 11 May 2024 08:18:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=d+4o8o8+VCsPIXoPhgBxDzwXRLzQgV+v2M1AHllS1ro=; b=ARQqkQ+oFtwg hwjgRtzg7mZJNIuF8vSsfW0wqSENoIToPgFroT1aqWQAJ8oJPIvkmg+L1r3CMxzKBemuif5cDlM4E gFwKF2Dk23LprkF7iguklFr/ECuwl09kuQ+16iuySqxOmBL9udvmNVWtxeih8n5yOVweUinbfMcP6 E4tukvWu+FGtONiRXw6ON6nHA3QZENnfewxaf7C0ZU5ESdB46NwX4BXFVKe9PbaH9LJr/SSAEmes8 fugp3oWn3Tg5B+9z+7/eUiLPcdAJWeDaKBQsWVDVxx1rpzaqQmOFPdzLOWrpWAHGHG/kg0oCbKCF7 RGjlEpzKZazOHtta9Z9XOw==; In-Reply-To: <40cfb760-bf82-4a02-bca5-bec81a00e619@gmail.com> (message from Sergey Vinokurov on Sat, 11 May 2024 13:12:33 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284864 Archived-At: > Date: Sat, 11 May 2024 13:12:33 +0100 > Cc: p.stephani2@gmail.com, dancol@dancol.org, 69953@debbugs.gnu.org > From: Sergey Vinokurov > > On 11/05/2024 11:02, Eli Zaretskii wrote: > >> Date: Thu, 9 May 2024 15:16:05 +0100 > >> Cc: 69953@debbugs.gnu.org > >> From: Sergey Vinokurov > >> > >>>>>> I added Daniel and Philipp to the discussion, in case they have > >>>>>> comments to this proposal. > >>> > >>> Given the lack of comments, I conclude that there's no interest in > >>> installing this, and I'm therefore closing this bug. > >> > >> I'm interested to get this installed - can I do anything to facilitate? > > > > Given the lack of responses, I doubt that. > > Is there no way to reevaluate the patch from the start? It's fairly > small, perhaps I did poor job explaining why it's good idea? AFAIU, the code isn't wrong, and doesn't cause any problems. You just think it's redundant. That's a judgment call, and without Daniel and Philipp, who worked on most of this case, assessing the proposal, I don't want to change code that worked well for us for several Emacs releases, just because it might be redundant. Why are you so eager to install these changes?