From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71741: 30.0.60; Wrong type argument: number-or-marker-p after C-x C-+ in eww Date: Mon, 24 Jun 2024 14:58:46 +0300 Message-ID: <86wmmeblhl.fsf@gnu.org> References: <8734p38d8h.fsf@pretzelnet.org> <1c42d70b-e494-9495-4759-56a2acade7fe@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7418"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 71741@debbugs.gnu.org, stefankangas@gmail.com, epg@pretzelnet.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 24 14:00:38 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLiNB-0001kC-7e for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jun 2024 14:00:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLiMe-0002BD-CS; Mon, 24 Jun 2024 08:00:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLiMd-0002Ao-J0 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 08:00:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLiMc-0005SE-2i for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 08:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLiMd-0000C0-0f for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 08:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2024 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71741 X-GNU-PR-Package: emacs Original-Received: via spool by 71741-submit@debbugs.gnu.org id=B71741.1719230343532 (code B ref 71741); Mon, 24 Jun 2024 12:00:02 +0000 Original-Received: (at 71741) by debbugs.gnu.org; 24 Jun 2024 11:59:03 +0000 Original-Received: from localhost ([127.0.0.1]:54293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLiLf-00008T-Bo for submit@debbugs.gnu.org; Mon, 24 Jun 2024 07:59:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLiLd-00007z-G4 for 71741@debbugs.gnu.org; Mon, 24 Jun 2024 07:59:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLiLW-0005GJ-Ja; Mon, 24 Jun 2024 07:58:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oJD02slS2FFk8SVAYba1ddK6nX67eqS0AoxdyVBUU4E=; b=VX5tCefEpJsC dbP03NjMY3/6GTEfAKsAUbkE7rgR3jgi0tHrynwix+9sb7RLba87Nh6tYocU6kONNjvOxXeID8zF4 /Gx3hinNV5CVtDGdOYl5WAcplh4wqBjC1DHsMyZw+FzRrytWOLs/hchYySdjsGUkP4mym0h7/1mR4 7qz/I1s+yto8oy69t8MIL5kN37iMja05oQxL7dSkT47/YsL45FZBgd2sQT827ML3C+aUaq75lZDlp KyJ3h9aUGfXlPFb+4szWWQv+AQy4ANNuRWXNRI+/R0e9UDsPiuscki5h2qSc+sAS9RX0qyd52yPFM DXfVZWod/OBX9NyjN2dYVQ==; In-Reply-To: <1c42d70b-e494-9495-4759-56a2acade7fe@gmail.com> (message from Jim Porter on Sun, 23 Jun 2024 17:32:36 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287830 Archived-At: > Cc: Po Lu > Date: Sun, 23 Jun 2024 17:32:36 -0700 > From: Jim Porter > > > I can reproduce this bug. Copying in Po Lu. > > I was just looking at image scaling in an unrelated bug, so I had > already swapped in all the necessary mental context for this. Here's a > patch. > > The second part fixes a closely-related issue: the scaling didn't work > for sliced images (you can get a sliced image by zooming it: put point > on the image and press "z"). > > Fixing that required fixing a bug in 'get-display-property': it only > returned the CAR of the display property value. To maintain backwards > compatibility, I changed it so that it still returns the CAR if there's > only one element, but it now returns the whole list if there are > multiple elements. I don't love this, and maybe we should always return > a list, but I'll leave that decision to others (for what it's worth, > 'get-display-property' is new in Emacs 29, so there hopefully aren't too > many uses of it out in the wild yet). > > I think the first patch is definitely worth merging to Emacs 30, but the > second I'm neutral on. Maybe we should fix 'get-display-property' now? I think changes in get-display-property and in find_display_property must wait for Emacs 31. They are used in too many places to be a safe change for the release branch. The first patch is okay for the release branch, assuming Po Lu agrees with it. Thanks.