all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: luangruo@yahoo.com, 71741@debbugs.gnu.org,
	stefankangas@gmail.com, epg@pretzelnet.org
Subject: bug#71741: 30.0.60; Wrong type argument: number-or-marker-p after C-x C-+ in eww
Date: Mon, 24 Jun 2024 14:58:46 +0300	[thread overview]
Message-ID: <86wmmeblhl.fsf@gnu.org> (raw)
In-Reply-To: <1c42d70b-e494-9495-4759-56a2acade7fe@gmail.com> (message from Jim Porter on Sun, 23 Jun 2024 17:32:36 -0700)

> Cc: Po Lu <luangruo@yahoo.com>
> Date: Sun, 23 Jun 2024 17:32:36 -0700
> From: Jim Porter <jporterbugs@gmail.com>
> 
> > I can reproduce this bug.  Copying in Po Lu.
> 
> I was just looking at image scaling in an unrelated bug, so I had 
> already swapped in all the necessary mental context for this. Here's a 
> patch.
> 
> The second part fixes a closely-related issue: the scaling didn't work 
> for sliced images (you can get a sliced image by zooming it: put point 
> on the image and press "z").
> 
> Fixing that required fixing a bug in 'get-display-property': it only 
> returned the CAR of the display property value. To maintain backwards 
> compatibility, I changed it so that it still returns the CAR if there's 
> only one element, but it now returns the whole list if there are 
> multiple elements. I don't love this, and maybe we should always return 
> a list, but I'll leave that decision to others (for what it's worth, 
> 'get-display-property' is new in Emacs 29, so there hopefully aren't too 
> many uses of it out in the wild yet).
> 
> I think the first patch is definitely worth merging to Emacs 30, but the 
> second I'm neutral on. Maybe we should fix 'get-display-property' now?

I think changes in get-display-property and in find_display_property
must wait for Emacs 31.  They are used in too many places to be a safe
change for the release branch.

The first patch is okay for the release branch, assuming Po Lu agrees
with it.

Thanks.





  reply	other threads:[~2024-06-24 11:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-23 23:13 bug#71741: 30.0.60; Wrong type argument: number-or-marker-p after C-x C-+ in eww epg
2024-06-23 23:24 ` Stefan Kangas
2024-06-24  0:32   ` Jim Porter
2024-06-24 11:58     ` Eli Zaretskii [this message]
2024-06-24 12:38       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-24 21:04       ` Jim Porter
2024-06-24 21:56         ` Stefan Kangas
2024-06-25  4:39           ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wmmeblhl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=71741@debbugs.gnu.org \
    --cc=epg@pretzelnet.org \
    --cc=jporterbugs@gmail.com \
    --cc=luangruo@yahoo.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.