Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers

Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers

[Arash Esbati]

Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

> branch: master
> commit 6aa5068ac71cb1b8e46c299138f99fea44319146
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
>     Improve treatment of touch screen input by rmc and its callers
>     
>     * lisp/emacs-lisp/rmc.el (read-multiple-choice--short-answers):
>     Run touch screen event translation on touch screen events
>     received, and respond to pinch, tap and scrolling gestures.
>     
>     * lisp/net/nsm.el (nsm-query-user): Disable use-dialog-box in
>     the details window.
>     
>     * lisp/touch-screen.el (touch-screen-translate-touch): Autoload.
> ---
>  lisp/emacs-lisp/rmc.el | 106 +++++++++++++++++++++++++++++++++----------------
>  lisp/net/nsm.el        |  11 ++++-
>  lisp/touch-screen.el   |   1 +
>  3 files changed, 81 insertions(+), 37 deletions(-)
>
> diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el
> index 378687c0326..883f8bf187f 100644
> --- a/lisp/emacs-lisp/rmc.el
> +++ b/lisp/emacs-lisp/rmc.el
>[...]
> +                  (cond
> +                   ((null command)) ; Read another event.
> +                   ((memq (car-safe command) '(mouse-1 mouse-2))
> +                    ;; Display the on-screen keyboard if a tap should be
> +                    ;; registered.
> +                    (frame-toggle-on-screen-keyboard (selected-frame)
> +                                                     nil))
> +                   ;; Respond to scroll and pinch events as if RMC were
> +                   ;; not in progress.
> +                   ((eq (car-safe command) 'touchscreen-scroll)
> +                    (funcall #'touch-screen-scroll command))
> +                   ((eq (car-safe command) 'touchscreen-pinch)
> +                    (funcall #'touch-screen-pinch command))

I think this part now generates:

In end of data:
rmc.el:245:32: Warning: the function ‘touch-screen-pinch’ is not known to be defined.
rmc.el:243:32: Warning: the function ‘touch-screen-scroll’ is not known to be defined.

This on macOS with Emacs from master (e6f4370c).

Best, Arash

Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers

[Po Lu]

Arash Esbati <arash@gnu.org> writes:

> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
>> branch: master
>> commit 6aa5068ac71cb1b8e46c299138f99fea44319146
>> Author: Po Lu <luangruo@yahoo.com>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>>     Improve treatment of touch screen input by rmc and its callers
>>     
>>     * lisp/emacs-lisp/rmc.el (read-multiple-choice--short-answers):
>>     Run touch screen event translation on touch screen events
>>     received, and respond to pinch, tap and scrolling gestures.
>>     
>>     * lisp/net/nsm.el (nsm-query-user): Disable use-dialog-box in
>>     the details window.
>>     
>>     * lisp/touch-screen.el (touch-screen-translate-touch): Autoload.
>> ---
>>  lisp/emacs-lisp/rmc.el | 106 +++++++++++++++++++++++++++++++++----------------
>>  lisp/net/nsm.el        |  11 ++++-
>>  lisp/touch-screen.el   |   1 +
>>  3 files changed, 81 insertions(+), 37 deletions(-)
>>
>> diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el
>> index 378687c0326..883f8bf187f 100644
>> --- a/lisp/emacs-lisp/rmc.el
>> +++ b/lisp/emacs-lisp/rmc.el
>>[...]
>> +                  (cond
>> +                   ((null command)) ; Read another event.
>> +                   ((memq (car-safe command) '(mouse-1 mouse-2))
>> +                    ;; Display the on-screen keyboard if a tap should be
>> +                    ;; registered.
>> +                    (frame-toggle-on-screen-keyboard (selected-frame)
>> +                                                     nil))
>> +                   ;; Respond to scroll and pinch events as if RMC were
>> +                   ;; not in progress.
>> +                   ((eq (car-safe command) 'touchscreen-scroll)
>> +                    (funcall #'touch-screen-scroll command))
>> +                   ((eq (car-safe command) 'touchscreen-pinch)
>> +                    (funcall #'touch-screen-pinch command))
>
> I think this part now generates:
>
> In end of data:
> rmc.el:245:32: Warning: the function ‘touch-screen-pinch’ is not known to be defined.
> rmc.el:243:32: Warning: the function ‘touch-screen-scroll’ is not known to be defined.
>
> This on macOS with Emacs from master (e6f4370c).

OK, what if you replace in:

>> +                   ;; Respond to scroll and pinch events as if RMC were
>> +                   ;; not in progress.
>> +                   ((eq (car-safe command) 'touchscreen-scroll)
>> +                    (funcall #'touch-screen-scroll command))
>> +                   ((eq (car-safe command) 'touchscreen-pinch)
>> +                    (funcall #'touch-screen-pinch command))

#'touch-screen-scroll and #'touch-screen-pinch with 'touch-screen-scroll
and 'touch-screen-pinch?

Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers

[Arash Esbati]

Po Lu <luangruo@yahoo.com> writes:

> OK, what if you replace in:
>
>>> +                   ;; Respond to scroll and pinch events as if RMC were
>>> +                   ;; not in progress.
>>> +                   ((eq (car-safe command) 'touchscreen-scroll)
>>> +                    (funcall #'touch-screen-scroll command))
>>> +                   ((eq (car-safe command) 'touchscreen-pinch)
>>> +                    (funcall #'touch-screen-pinch command))
>
> #'touch-screen-scroll and #'touch-screen-pinch with 'touch-screen-scroll
> and 'touch-screen-pinch?

"Hiding" them from the compiler didn't work, the following change did:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el
index 883f8bf187f..a9142a8b46b 100644
--- a/lisp/emacs-lisp/rmc.el
+++ b/lisp/emacs-lisp/rmc.el
@@ -179,6 +179,9 @@ read-multiple-choice
     (read-multiple-choice--short-answers
      prompt choices help-string show-help)))

+(declare-function touch-screen-scroll "touch-screen" (event))
+(declare-function touch-screen-pinch "touch-screen" (event))
+
 (defun read-multiple-choice--short-answers (prompt choices help-string show-help)
   (let* ((dialog-p (use-dialog-box-p))
          (prompt-choices
--8<---------------cut here---------------end--------------->8---

Best, Arash

Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Wed, 19 Jun 2024 13:42:17 +0200
> 
> Po Lu <luangruo@yahoo.com> writes:
> 
> > OK, what if you replace in:
> >
> >>> +                   ;; Respond to scroll and pinch events as if RMC were
> >>> +                   ;; not in progress.
> >>> +                   ((eq (car-safe command) 'touchscreen-scroll)
> >>> +                    (funcall #'touch-screen-scroll command))
> >>> +                   ((eq (car-safe command) 'touchscreen-pinch)
> >>> +                    (funcall #'touch-screen-pinch command))
> >
> > #'touch-screen-scroll and #'touch-screen-pinch with 'touch-screen-scroll
> > and 'touch-screen-pinch?
> 
> "Hiding" them from the compiler didn't work, the following change did:
> 
> --8<---------------cut here---------------start------------->8---
> diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el
> index 883f8bf187f..a9142a8b46b 100644
> --- a/lisp/emacs-lisp/rmc.el
> +++ b/lisp/emacs-lisp/rmc.el
> @@ -179,6 +179,9 @@ read-multiple-choice
>      (read-multiple-choice--short-answers
>       prompt choices help-string show-help)))
> 
> +(declare-function touch-screen-scroll "touch-screen" (event))
> +(declare-function touch-screen-pinch "touch-screen" (event))
> +
>  (defun read-multiple-choice--short-answers (prompt choices help-string show-help)
>    (let* ((dialog-p (use-dialog-box-p))
>           (prompt-choices
> --8<---------------cut here---------------end--------------->8---

Ping!