From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71935: split-string-and-unquote mishandles dired-listing-switches with ' Date: Thu, 04 Jul 2024 22:03:00 +0300 Message-ID: <86wmm16kuz.fsf@gnu.org> References: <86tth5tztt.fsf@mail.linkov.net> <86zfqx8tnn.fsf@gnu.org> <86a5ixqhd4.fsf@mail.linkov.net> <868qyh82is.fsf@gnu.org> <8634opowlq.fsf@mail.linkov.net> <8634op80r5.fsf@gnu.org> <86tth52dkl.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12995"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71935@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 21:06:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPRmV-0003Al-J7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 21:06:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPRmL-0003Yr-S5; Thu, 04 Jul 2024 15:06:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPRmJ-0003VY-LY for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 15:05:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPRmJ-0007Lu-E2 for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 15:05:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPRmL-0002Uq-Sm for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 15:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 19:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71935 X-GNU-PR-Package: emacs Original-Received: via spool by 71935-submit@debbugs.gnu.org id=B71935.17201199259546 (code B ref 71935); Thu, 04 Jul 2024 19:06:01 +0000 Original-Received: (at 71935) by debbugs.gnu.org; 4 Jul 2024 19:05:25 +0000 Original-Received: from localhost ([127.0.0.1]:42994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPRll-0002Tt-8k for submit@debbugs.gnu.org; Thu, 04 Jul 2024 15:05:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPRlj-0002Tg-M3 for 71935@debbugs.gnu.org; Thu, 04 Jul 2024 15:05:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPRjU-00056Z-Fl; Thu, 04 Jul 2024 15:03:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jaueSfvnOcYTYd9lzFIvebis1i5B4t+PU/sBmxzvfa0=; b=El9kQfASU96H RhdNaUxZhbElxNt+tIWfeAtAs+jhhkhFbk4PMLnezg5CbgTjFgyZFTmXTPxlJJJfDWRb3JtllQ1Im Kt2cXmT7yC7zrIYk/ZK6n17QEc9Lpi1OiDltbbnqGpwefvNJ09nD22nHWOWLyKgV9G3hw9P/qCscy 5Q9ZydgtADDI8itAh5uE8pHKwUqLmjJXT9mS+/r49dqAZRv3VKUDlDKQlJXCPPw5egQwfhaGYZn3X WbzcmUq4uQVQR2RsUHIZO6u9OhsCQoqJsaFOVMl5gaEeptpN72K8IdhB7EjBe4IVqz6i2OZedLrGy aNLkwJvONLaDyEXalZ93cA==; In-Reply-To: <86tth52dkl.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 04 Jul 2024 21:54:02 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288394 Archived-At: > From: Juri Linkov > Cc: 71935@debbugs.gnu.org > Date: Thu, 04 Jul 2024 21:54:02 +0300 > > >>> 1. (setopt dired-listing-switches "-al --block-size='1") > >>> 2. C-x d /tmp/* > > > > If they are a single string, split it with split-string-and-unquote, > > then concatenate after running each one through shell-quote-argument. > > If they are a list of strings, quote each one before concatenating > > with mapconcat. > > Ok, this seems to work: > > diff --git a/lisp/files.el b/lisp/files.el > index 042b8e2d515..6ed07f02890 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -8195,9 +8193,11 @@ insert-directory > "\\") ; Disregard Unix shell aliases! > insert-directory-program > " -d " > - (if (stringp switches) > - switches > - (mapconcat #'identity switches " ")) > + (mapconcat #'shell-quote-argument > + (if (stringp switches) > + (split-string-and-unquote switches) > + switches) > + " ") > " -- " > ;; Quote some characters that have > ;; special meanings in shells; but > Thanks, that's what I had in mind. Please install on the emacs-30 branch.