bug#70716: flymake-cc creates `-.o` files

bug#70716: flymake-cc creates `-.o` files

[Mattias Engdegård]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

`flymake-cc-use-special-make-target`, the standard value for `flymake-cc-command`, generates a command like

  make check-syntax CHK_SOURCES="-x c -c -"

which causes the compiler (at least Clang) to create the file `-.o` that is never cleaned up and whose name is mysterious and awkward to remove.

What about the patch below?


[-- Attachment #2: flymake-cc-null-output.diff --]
[-- Type: application/octet-stream, Size: 637 bytes --]

diff --git a/lisp/progmodes/flymake-cc.el b/lisp/progmodes/flymake-cc.el
index 60e7da5d617..01f463454e9 100644
--- a/lisp/progmodes/flymake-cc.el
+++ b/lisp/progmodes/flymake-cc.el
@@ -95,9 +95,10 @@ flymake-cc-use-special-make-target
   (unless (executable-find "make") (error "Make not found"))
   `("make"
     "check-syntax"
-    ,(format "CHK_SOURCES=-x %s -c -"
+    ,(format "CHK_SOURCES=-x %s -c - -o %s"
              (cond ((derived-mode-p 'c++-mode) "c++")
-                   (t "c")))))
+                   (t "c"))
+             null-device)))
 
 (defvar-local flymake-cc--proc nil "Internal variable for `flymake-cc'.")
 

bug#70716: flymake-cc creates `-.o` files

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

On Thu, May 2, 2024 at 2:10 PM Mattias Engdegård <
mattias.engdegard@gmail.com> wrote:

> `flymake-cc-use-special-make-target`, the standard value for
> `flymake-cc-command`, generates a command like
>
>   make check-syntax CHK_SOURCES="-x c -c -"
>
> which causes the compiler (at least Clang) to create the file `-.o` that
> is never cleaned up and whose name is mysterious and awkward to remove.
>
> What about the patch below?
>

Copying in Spencer Baugh, the new Flymake maintainer.

João

[-- Attachment #2: Type: text/html, Size: 898 bytes --]

bug#70716: flymake-cc creates `-.o` files

[Mattias Engdegård]

2 maj 2024 kl. 15.13 skrev João Távora <joaotavora@gmail.com>:

> Copying in Spencer Baugh, the new Flymake maintainer. 

Would either of you please update the `Maintainer:` lines in lisp/progmodes/flymake*.el then?

bug#70716: flymake-cc creates `-.o` files

[Eli Zaretskii]

> Cc: sbaugh@catern.com, 70716@debbugs.gnu.org
> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Thu, 2 May 2024 16:00:08 +0200
> 
> 2 maj 2024 kl. 15.13 skrev João Távora <joaotavora@gmail.com>:
> 
> > Copying in Spencer Baugh, the new Flymake maintainer. 
> 
> Would either of you please update the `Maintainer:` lines in lisp/progmodes/flymake*.el then?

Spencer, is it okay to mention you there as the maintainer of Flymake?

bug#70716: flymake-cc creates `-.o` files

[Eli Zaretskii]

> Cc: 70716@debbugs.gnu.org
> From: João Távora <joaotavora@gmail.com>
> Date: Thu, 2 May 2024 14:13:49 +0100
> 
> On Thu, May 2, 2024 at 2:10 PM Mattias Engdegård <mattias.engdegard@gmail.com> wrote:
> 
>  `flymake-cc-use-special-make-target`, the standard value for `flymake-cc-command`, generates a
>  command like
> 
>    make check-syntax CHK_SOURCES="-x c -c -"
> 
>  which causes the compiler (at least Clang) to create the file `-.o` that is never cleaned up and whose
>  name is mysterious and awkward to remove.
> 
>  What about the patch below?
> 
>  
> Copying in Spencer Baugh, the new Flymake maintainer. 

Spencer, any comments or suggestions or patches?

Thanks.

bug#70716: flymake-cc creates `-.o` files

[Eli Zaretskii]

Ping!

> Cc: sbaugh@catern.com, 70716@debbugs.gnu.org, joaotavora@gmail.com
> Date: Sat, 04 May 2024 14:38:39 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Cc: sbaugh@catern.com, 70716@debbugs.gnu.org
> > From: Mattias Engdegård <mattias.engdegard@gmail.com>
> > Date: Thu, 2 May 2024 16:00:08 +0200
> > 
> > 2 maj 2024 kl. 15.13 skrev João Távora <joaotavora@gmail.com>:
> > 
> > > Copying in Spencer Baugh, the new Flymake maintainer. 
> > 
> > Would either of you please update the `Maintainer:` lines in lisp/progmodes/flymake*.el then?
> 
> Spencer, is it okay to mention you there as the maintainer of Flymake?
> 
> 
> 
> 

bug#70716: flymake-cc creates `-.o` files

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: 70716@debbugs.gnu.org
>> From: João Távora <joaotavora@gmail.com>
>> Date: Thu, 2 May 2024 14:13:49 +0100
>>
>> On Thu, May 2, 2024 at 2:10 PM Mattias Engdegård <mattias.engdegard@gmail.com> wrote:
>>
>>  `flymake-cc-use-special-make-target`, the standard value for `flymake-cc-command`, generates a
>>  command like
>>
>>    make check-syntax CHK_SOURCES="-x c -c -"
>>
>>  which causes the compiler (at least Clang) to create the file `-.o` that is never cleaned up and whose
>>  name is mysterious and awkward to remove.
>>
>>  What about the patch below?
>>
>>
>> Copying in Spencer Baugh, the new Flymake maintainer.
>
> Spencer, any comments or suggestions or patches?
>
> Thanks.

Ping.

bug#70716: flymake-cc creates `-.o` files

[Eli Zaretskii]

Ping! Spencer, would you please chime in?

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sat, 29 Jun 2024 22:45:50 -0700
> Cc: João Távora <joaotavora@gmail.com>, sbaugh@catern.com, 
> 	mattias.engdegard@gmail.com, 70716@debbugs.gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Cc: 70716@debbugs.gnu.org
> >> From: João Távora <joaotavora@gmail.com>
> >> Date: Thu, 2 May 2024 14:13:49 +0100
> >>
> >> On Thu, May 2, 2024 at 2:10 PM Mattias Engdegård <mattias.engdegard@gmail.com> wrote:
> >>
> >>  `flymake-cc-use-special-make-target`, the standard value for `flymake-cc-command`, generates a
> >>  command like
> >>
> >>    make check-syntax CHK_SOURCES="-x c -c -"
> >>
> >>  which causes the compiler (at least Clang) to create the file `-.o` that is never cleaned up and whose
> >>  name is mysterious and awkward to remove.
> >>
> >>  What about the patch below?
> >>
> >>
> >> Copying in Spencer Baugh, the new Flymake maintainer.
> >
> > Spencer, any comments or suggestions or patches?
> >
> > Thanks.
> 
> Ping.
> 

bug#70716: flymake-cc creates `-.o` files

[Eli Zaretskii]

Ping! Ping!  Spencer, please respond.

> Cc: mattias.engdegard@gmail.com, joaotavora@gmail.com, 70716@debbugs.gnu.org
> Date: Sat, 20 Jul 2024 13:10:52 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> Ping! Spencer, would you please chime in?
> 
> > From: Stefan Kangas <stefankangas@gmail.com>
> > Date: Sat, 29 Jun 2024 22:45:50 -0700
> > Cc: João Távora <joaotavora@gmail.com>, sbaugh@catern.com, 
> > 	mattias.engdegard@gmail.com, 70716@debbugs.gnu.org
> > 
> > Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > >> Cc: 70716@debbugs.gnu.org
> > >> From: João Távora <joaotavora@gmail.com>
> > >> Date: Thu, 2 May 2024 14:13:49 +0100
> > >>
> > >> On Thu, May 2, 2024 at 2:10 PM Mattias Engdegård <mattias.engdegard@gmail.com> wrote:
> > >>
> > >>  `flymake-cc-use-special-make-target`, the standard value for `flymake-cc-command`, generates a
> > >>  command like
> > >>
> > >>    make check-syntax CHK_SOURCES="-x c -c -"
> > >>
> > >>  which causes the compiler (at least Clang) to create the file `-.o` that is never cleaned up and whose
> > >>  name is mysterious and awkward to remove.
> > >>
> > >>  What about the patch below?
> > >>
> > >>
> > >> Copying in Spencer Baugh, the new Flymake maintainer.
> > >
> > > Spencer, any comments or suggestions or patches?
> > >
> > > Thanks.
> > 
> > Ping.
> > 
> 
> 
> 
> 

bug#70716: flymake-cc creates `-.o` files

[Eli Zaretskii]

Ping! Ping! Ping!  Spencer, are you there?

> Cc: mattias.engdegard@gmail.com, stefankangas@gmail.com, 70716@debbugs.gnu.org,
>  joaotavora@gmail.com
> Date: Sun, 04 Aug 2024 10:55:48 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> Ping! Ping!  Spencer, please respond.
> 
> > Cc: mattias.engdegard@gmail.com, joaotavora@gmail.com, 70716@debbugs.gnu.org
> > Date: Sat, 20 Jul 2024 13:10:52 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > 
> > Ping! Spencer, would you please chime in?
> > 
> > > From: Stefan Kangas <stefankangas@gmail.com>
> > > Date: Sat, 29 Jun 2024 22:45:50 -0700
> > > Cc: João Távora <joaotavora@gmail.com>, sbaugh@catern.com, 
> > > 	mattias.engdegard@gmail.com, 70716@debbugs.gnu.org
> > > 
> > > Eli Zaretskii <eliz@gnu.org> writes:
> > > 
> > > >> Cc: 70716@debbugs.gnu.org
> > > >> From: João Távora <joaotavora@gmail.com>
> > > >> Date: Thu, 2 May 2024 14:13:49 +0100
> > > >>
> > > >> On Thu, May 2, 2024 at 2:10 PM Mattias Engdegård <mattias.engdegard@gmail.com> wrote:
> > > >>
> > > >>  `flymake-cc-use-special-make-target`, the standard value for `flymake-cc-command`, generates a
> > > >>  command like
> > > >>
> > > >>    make check-syntax CHK_SOURCES="-x c -c -"
> > > >>
> > > >>  which causes the compiler (at least Clang) to create the file `-.o` that is never cleaned up and whose
> > > >>  name is mysterious and awkward to remove.
> > > >>
> > > >>  What about the patch below?
> > > >>
> > > >>
> > > >> Copying in Spencer Baugh, the new Flymake maintainer.
> > > >
> > > > Spencer, any comments or suggestions or patches?
> > > >
> > > > Thanks.
> > > 
> > > Ping.
> > > 
> > 
> > 
> > 
> > 
> 
> 
> 
> 

bug#70716: flymake-cc creates `-.o` files

[sbaugh]

Mattias Engdegård <mattias.engdegard@gmail.com> writes:
> `flymake-cc-use-special-make-target`, the standard value for `flymake-cc-command`, generates a command like
>
>   make check-syntax CHK_SOURCES="-x c -c -"
>
> which causes the compiler (at least Clang) to create the file `-.o` that is never cleaned up and whose name is mysterious and awkward to remove.
>
> What about the patch below?

(info "(flymake) Example---Configuring a tool called via make")

mentions a check-syntax target looking like:

check-syntax:
	gcc -o /dev/null -S ${CHK_SOURCES} || true

So it seems like it would be better to add this -o /dev/null in your
Makefile.

That also allows you to run, e.g.,

  make check-syntax CHK_SOURCES="file1.c file2.c"

from a shell or M-x compile.

So I think this is a bug in your Makefile, not flymake-cc.

But, also, probably the docstring of flymake-cc-use-special-make-target
should be updated to link to the manual.  And probably the manual should
mention that CHK_SOURCES can be an explicit list of files too.

BTW, the CHK_SOURCES target mentioned by flymake is, AFAICT from web
searches, completely unique to flymake.  I wonder if there's a more
standard alternative... but we probably can't change the default of
flymake-cc-command anyway.

bug#70716: flymake-cc creates `-.o` files

[Spencer Baugh]

Eli Zaretskii <eliz@gnu.org> writes:
> Ping! Ping! Ping!  Spencer, are you there?

My apologies, I had an issue causing me to not receive these emails.

I think it would be best to list sbaugh@janestreet.com as the Flymake
maintainer, since I'm more likely to receive such emails.

bug#70716: flymake-cc creates `-.o` files

[Mattias Engdegård]

28 aug. 2024 kl. 19.01 skrev sbaugh@catern.com:

> check-syntax:
> 	gcc -o /dev/null -S ${CHK_SOURCES} || true
> 
> So it seems like it would be better to add this -o /dev/null in your
> Makefile.

Actually not my Makefile but that of flymake-tests.
Anyway, now done on master, thank you!