bug#73082: 30; Inconsistent Stipple Support

bug#73082: 30; Inconsistent Stipple Support

[JD Smith]

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

The :stipple face attribute is not consistently supported across all Emacs 30 builds, with incorrect or missing stipple display for NS and GTK+Cairo builds.  

The following test of :stipple should lead to an image similar to the attached.

(let* ((w (window-font-width))
       (stipple `(,w 1 ,(apply #'unibyte-string (make-list (/ (+ w 7) 8) 186)))))
  (insert "\n" (propertize (concat  (make-string 15 ?\s)
				    "THIS IS A TEST"
				    (make-string 15 ?\s))
                           'face `(:background "red" :foreground "blue" :stipple ,stipple))))

Only some Emacs 30 builds correctly render this simple stipple.  There has been some progress on :stipple support recently, but it remains incomplete.  To my knowledge, the current situation for :stipple support in Emacs 30 is as follows:
NS (partially working): Commit ef6ffbdc79 from last May provided a partial fix, but stipples are black and white only (bug#70712)
Windows (working?): patched in June (bug#71159)
PGTK (working): incorrect stipple display patched July, 2023 (bug#64969)
GTK, non-Cairo (working): appears to be working correctly
GTK + Cairo (not working uniformly): Stipples are reported to be missing with some Cairo builds of Emacs 30
Other X11 builds (?): Unsure if these are supported (but suspect they are given the legacy of stipple)



[-- Attachment #2.1: Type: text/html, Size: 7740 bytes --]

[-- Attachment #2.2: image.png --]
[-- Type: image/png, Size: 12971 bytes --]

bug#73082: 30; Inconsistent Stipple Support

[Eli Zaretskii]

> Cc: Po Lu <luangruo@yahoo.com>
> From: JD Smith <jdtsmith@gmail.com>
> Date: Fri, 6 Sep 2024 17:58:02 -0400
> 
> (let* ((w (window-font-width))
>        (stipple `(,w 1 ,(apply #'unibyte-string (make-list (/ (+ w 7) 8) 186)))))
>   (insert "\n" (propertize (concat  (make-string 15 ?\s)
> 				    "THIS IS A TEST"
> 				    (make-string 15 ?\s))
>                            'face `(:background "red" :foreground "blue" :stipple ,stipple))))
> 
> Only some Emacs 30 builds correctly render this simple stipple.  There has been some progress on :stipple support recently, but it remains incomplete.  To my knowledge, the current situation for :stipple support in Emacs 30 is as follows:
> NS (partially working): Commit ef6ffbdc79 from last May provided a partial fix, but stipples are black and white only (bug#70712)
> Windows (working?): patched in June (bug#71159)
> PGTK (working): incorrect stipple display patched July, 2023 (bug#64969)
> GTK, non-Cairo (working): appears to be working correctly
> GTK + Cairo (not working uniformly): Stipples are reported to be missing with some Cairo builds of Emacs 30
> Other X11 builds (?): Unsure if these are supported (but suspect they are given the legacy of stipple)

The MS-Windows build of the emacs-30 branch here shows the display you
expected.

bug#73082: 30; Inconsistent Stipple Support

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: Po Lu <luangruo@yahoo.com>
>> From: JD Smith <jdtsmith@gmail.com>
>> Date: Fri, 6 Sep 2024 17:58:02 -0400
>> 
>> (let* ((w (window-font-width))
>>        (stipple `(,w 1 ,(apply #'unibyte-string (make-list (/ (+ w 7) 8) 186)))))
>>   (insert "\n" (propertize (concat  (make-string 15 ?\s)
>> 				    "THIS IS A TEST"
>> 				    (make-string 15 ?\s))
>>                            'face `(:background "red" :foreground "blue" :stipple ,stipple))))
>> 
>> Only some Emacs 30 builds correctly render this simple stipple.  There has been some progress on :stipple support recently, but it remains incomplete.  To my knowledge, the current situation for :stipple support in Emacs 30 is as follows:
>> NS (partially working): Commit ef6ffbdc79 from last May provided a partial fix, but stipples are black and white only (bug#70712)
>> Windows (working?): patched in June (bug#71159)
>> PGTK (working): incorrect stipple display patched July, 2023 (bug#64969)
>> GTK, non-Cairo (working): appears to be working correctly
>> GTK + Cairo (not working uniformly): Stipples are reported to be missing with some Cairo builds of Emacs 30
>> Other X11 builds (?): Unsure if these are supported (but suspect they are given the legacy of stipple)
>
> The MS-Windows build of the emacs-30 branch here shows the display you
> expected.

You should add Haiku and Android to your list, as Emacs supports
stipples on both of these window systems.  (And on the latter they were
in fact implemented for your package.)

I am also interested to know precisely which Cairo builds fail to
display them, the stipple implementations being virtually identical
across the PGTK and the X + Cairo builds.

bug#73082: 30; Inconsistent Stipple Support

[JD Smith]

[-- Attachment #1: Type: text/plain, Size: 1980 bytes --]



> On Sep 7, 2024, at 2:51 AM, Po Lu <luangruo@yahoo.com> wrote:
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
>>> From: JD Smith <jdtsmith@gmail.com>
>>> Date: Fri, 6 Sep 2024 17:58:02 -0400
>>> 
>>> (let* ((w (window-font-width))
>>>       (stipple `(,w 1 ,(apply #'unibyte-string (make-list (/ (+ w 7) 8) 186)))))
>>>  (insert "\n" (propertize (concat  (make-string 15 ?\s)
>>> 				    "THIS IS A TEST"
>>> 				    (make-string 15 ?\s))
>>>                           'face `(:background "red" :foreground "blue" :stipple ,stipple))))
>>> 
>>> Only some Emacs 30 builds correctly render this simple stipple.  There has been some progress on :stipple support recently, but it remains incomplete.  To my knowledge, the current situation for :stipple support in Emacs 30 is as follows...
>> The MS-Windows build of the emacs-30 branch here shows the display you
>> expected.
> 
> You should add Haiku and Android to your list, as Emacs supports
> stipples on both of these window systems.  (And on the latter they were
> in fact implemented for your package.)
> 
> I am also interested to know precisely which Cairo builds fail to
> display them, the stipple implementations being virtually identical
> across the PGTK and the X + Cairo builds.

Thanks, this is all positive news.  Glad to learn of Android+Haiku support.  Is support on these builds arriving for Emacs 30 only?

The Cairo issue has been harder to track down.  Several users have reported Cairo builds which fail to display stipples.  I gather Cairo is the default so this must be a sporadic failure.  Recently a user with identical builds on two different machines, with the precise same version of GTK3 and Cairo, found that one system shows stipples correctly, the other omits them entirely.  On the non-working system, compiling --without-cairo resolves this.

The build version in questions is: 



He's willing to test these systems.  

Thanks for your work on this.

[-- Attachment #2.1: Type: text/html, Size: 3685 bytes --]

[-- Attachment #2.2: image.png --]
[-- Type: image/png, Size: 7602 bytes --]

bug#73082: 30; Inconsistent Stipple Support

[JD Smith]

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]


> The Cairo issue has been harder to track down.  Several users have reported Cairo builds which fail to display stipples.  I gather Cairo is the default so this must be a sporadic failure.  Recently a user with identical builds on two different machines, with the precise same version of GTK3 and Cairo, found that one system shows stipples correctly, the other omits them entirely.  On the non-working system, compiling --without-cairo resolves this.
> 
> The build version in questions is: 
> 
> 
> 
> He's willing to test these systems.  
> 

Copying in the affected user.  

[-- Attachment #2.1: Type: text/html, Size: 1272 bytes --]

[-- Attachment #2.2: image.png --]
[-- Type: image/png, Size: 7602 bytes --]

bug#73082: 30; Inconsistent Stipple Support

[JD Smith]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]


> On Sep 7, 2024, at 9:17 AM, JD Smith <jdtsmith@gmail.com> wrote:
> 
> On Sep 7, 2024, at 2:51 AM, Po Lu <luangruo@yahoo.com <mailto:luangruo@yahoo.com>> wrote:
> I am also interested to know precisely which Cairo builds fail to
> display them, the stipple implementations being virtually identical
> across the PGTK and the X + Cairo builds.

>> The Cairo issue has been harder to track down.  Several users have reported Cairo builds which fail to display stipples.  I gather Cairo is the default so this must be a sporadic failure.  Recently a user with identical builds on two different machines, with the precise same version of GTK3 and Cairo, found that one system shows stipples correctly, the other omits them entirely.  On the non-working system, compiling --without-cairo resolves this.

Po, did any potential causes for intermittent stipple display among identical Cairo builds occur to you?  Anything obvious to test?


[-- Attachment #2: Type: text/html, Size: 2066 bytes --]

bug#73082: 30; Inconsistent Stipple Support

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

JD Smith <jdtsmith@gmail.com> writes:

> Po, did any potential causes for intermittent stipple display among
> identical Cairo builds occur to you?  Anything obvious to test?

No, sorry.

bug#73082: 30; Inconsistent Stipple Support

[JD Smith]

> On Sep 13, 2024, at 8:33 PM, Po Lu <luangruo@yahoo.com> wrote:
> 
> JD Smith <jdtsmith@gmail.com> writes:
> 
>> Po, did any potential causes for intermittent stipple display among
>> identical Cairo builds occur to you?  Anything obvious to test?
> 
> No, sorry.

New clue on this end from user reports.  Building --with-cairo disables stipples.  Building --without-cairo yields good stipples.  Omitting any mention of Cairo among the build flags also yields good stipples (even with the same exact emacs-version).  

So something specific to the --with-cairo flag itself seems to be breaking stipples.  Very surprising.

bug#73082: 30; Inconsistent Stipple Support

[Arash Esbati]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

JD Smith <jdtsmith@gmail.com> writes:

> To my knowledge, the current situation for :stipple support in Emacs
> 30 is as follows:
>
> * NS (partially working): Commit ef6ffbdc79 from last May provided a
> partial fix, but stipples are black and white only (bug#70712)

FWIW, this is what I see on macOS with NS-port:

[-- Attachment #2: stipples-ns.png --]
[-- Type: image/png, Size: 5189 bytes --]

[-- Attachment #3: Type: text/plain, Size: 78 bytes --]


> * Windows (working?): patched in June (bug#71159)

And this is on Windows:

[-- Attachment #4: stipples-windows.png --]
[-- Type: image/png, Size: 1872 bytes --]

[-- Attachment #5: Type: text/plain, Size: 82 bytes --]


Both with "emacs -Q" incl. the value of `emacs-repository-version'.

Best, Arash