From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#73050: 30.0.90; Empty tool tip when hovering over tab-bar separator Date: Mon, 09 Sep 2024 20:17:03 +0300 Organization: LINKOV.NET Message-ID: <86wmjk692o.fsf@mail.linkov.net> References: <87r09ygit9.fsf@daniel-mendler.de> <86le03yeyv.fsf@gnu.org> <86jzfmu0lm.fsf@mail.linkov.net> <86jzfmwrnt.fsf@gnu.org> <86plpep099.fsf@mail.linkov.net> <86bk0yvxvy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27640"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: mail@daniel-mendler.de, 73050@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 09 19:20:36 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sni43-00071L-Ln for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Sep 2024 19:20:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sni3Z-0006IY-5E; Mon, 09 Sep 2024 13:20:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sni3T-0006HG-TP for bug-gnu-emacs@gnu.org; Mon, 09 Sep 2024 13:20:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sni3T-00053c-Kx for bug-gnu-emacs@gnu.org; Mon, 09 Sep 2024 13:19:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=ccqg3VSUySFxcKVtnXGro18wLEd0RDI0awXDGsc7OC4=; b=OYMazvS1pGaSP3NEWhQMXxAGv0mhRo7hqq0gF3iGvSuvjWUrRo5k6DJ4/4P6911n8rATErdGI7IiCyQBJI5h8Ju08OSOKD0fE1Fi4WEBecC+4UjehXuFq+rF36Y15R8ItvWDj1xUvOLauIf2ej4qDf40cwl7FI0vMhoEwc159zWdkUxpX1AqSdX/XLvOrBdYH1dDDOztR9Jhgp5K8JLdT9vdKlCkslmodmxcq0KHyZKUBQItFKV5AOEqIv5th6T9JhcT79JeTvcbZJ84cYBYoSFTL0wwFbNi4CzyQ96RQN0CIH6iGC9oI+0Me+Owl3Q/C4zDiEYMYVbmB9Krs4MPnQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sni3X-0001VA-E5 for bug-gnu-emacs@gnu.org; Mon, 09 Sep 2024 13:20:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Sep 2024 17:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73050 X-GNU-PR-Package: emacs Original-Received: via spool by 73050-submit@debbugs.gnu.org id=B73050.17259023495657 (code B ref 73050); Mon, 09 Sep 2024 17:20:03 +0000 Original-Received: (at 73050) by debbugs.gnu.org; 9 Sep 2024 17:19:09 +0000 Original-Received: from localhost ([127.0.0.1]:33962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sni2e-0001TA-QM for submit@debbugs.gnu.org; Mon, 09 Sep 2024 13:19:09 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:44007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sni2c-0001Se-Q7 for 73050@debbugs.gnu.org; Mon, 09 Sep 2024 13:19:07 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 0F8B720004; Mon, 9 Sep 2024 17:18:54 +0000 (UTC) In-Reply-To: <86bk0yvxvy.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 08 Sep 2024 20:49:37 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291518 Archived-At: >> >> Maybe this unasked-for default fallback is not needed after all: >> >> >> >> diff --git a/src/xdisp.c b/src/xdisp.c >> >> index f9a10267bad..18834c6b781 100644 >> >> --- a/src/xdisp.c >> >> +++ b/src/xdisp.c >> >> @@ -15155,8 +15155,6 @@ note_tab_bar_highlight (struct frame *f, int x, int y) >> >> help_echo_object = help_echo_window = Qnil; >> >> help_echo_pos = -1; >> >> help_echo_string = AREF (f->tab_bar_items, prop_idx + TAB_BAR_ITEM_HELP); >> >> - if (NILP (help_echo_string)) >> >> - help_echo_string = AREF (f->tab_bar_items, prop_idx + TAB_BAR_ITEM_CAPTION); >> >> } >> >> >> >> #endif /* HAVE_WINDOW_SYSTEM */ >> > >> > Do you remember why was this introduced? >> >> It was copy-pasted from tool-bar code. > > But on the tool bar there are no empty space between buttons. On the > tab bar, there is. What I don't understand is why those empty spaces > have tooltips. Because each tab-bar button has a valid, non-nil > tooltip, so the problem is with the tooltips popped up when the mouse > is between buttons. Do you understand why this happens? When there is no TAB_BAR_ITEM_HELP, then it falls back to TAB_BAR_ITEM_CAPTION. But the tab bar doesn't need tooltips on spaces. So this patch is needed.