all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mail@daniel-mendler.de, 73050@debbugs.gnu.org
Subject: bug#73050: 30.0.90; Empty tool tip when hovering over tab-bar separator
Date: Mon, 09 Sep 2024 20:17:03 +0300	[thread overview]
Message-ID: <86wmjk692o.fsf@mail.linkov.net> (raw)
In-Reply-To: <86bk0yvxvy.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 08 Sep 2024 20:49:37 +0300")

>> >> Maybe this unasked-for default fallback is not needed after all:
>> >>
>> >> diff --git a/src/xdisp.c b/src/xdisp.c
>> >> index f9a10267bad..18834c6b781 100644
>> >> --- a/src/xdisp.c
>> >> +++ b/src/xdisp.c
>> >> @@ -15155,8 +15155,6 @@ note_tab_bar_highlight (struct frame *f, int x, int y)
>> >>    help_echo_object = help_echo_window = Qnil;
>> >>    help_echo_pos = -1;
>> >>    help_echo_string = AREF (f->tab_bar_items, prop_idx + TAB_BAR_ITEM_HELP);
>> >> -  if (NILP (help_echo_string))
>> >> -    help_echo_string = AREF (f->tab_bar_items, prop_idx + TAB_BAR_ITEM_CAPTION);
>> >>  }
>> >>
>> >>  #endif /* HAVE_WINDOW_SYSTEM */
>> >
>> > Do you remember why was this introduced?
>> 
>> It was copy-pasted from tool-bar code.
>
> But on the tool bar there are no empty space between buttons.  On the
> tab bar, there is.  What I don't understand is why those empty spaces
> have tooltips.  Because each tab-bar button has a valid, non-nil
> tooltip, so the problem is with the tooltips popped up when the mouse
> is between buttons.  Do you understand why this happens?

When there is no TAB_BAR_ITEM_HELP, then it falls back to TAB_BAR_ITEM_CAPTION.
But the tab bar doesn't need tooltips on spaces.  So this patch is needed.





  reply	other threads:[~2024-09-09 17:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05 16:35 bug#73050: 30.0.90; Empty tool tip when hovering over tab-bar separator Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-07  9:45 ` Eli Zaretskii
2024-09-08  6:51   ` Juri Linkov
2024-09-08  7:06     ` Eli Zaretskii
2024-09-08 16:40       ` Juri Linkov
2024-09-08 17:49         ` Eli Zaretskii
2024-09-09 17:17           ` Juri Linkov [this message]
2024-09-09 17:44             ` Eli Zaretskii
2024-09-09 18:33               ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wmjk692o.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=73050@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mail@daniel-mendler.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.