From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Date: Sat, 21 Dec 2024 09:20:38 +0200 Message-ID: <86wmft8ptl.fsf@gnu.org> References: <20241219223632.37894-1-hong@topbug.net> <86pllmkfcm.fsf@gnu.org> <877c7u58iw.fsf@topbug.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26086"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, 74983@debbugs.gnu.org To: Hong Xu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 21 08:21:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOtnt-0006gD-BX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Dec 2024 08:21:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOtnM-0008NM-Se; Sat, 21 Dec 2024 02:21:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOtnK-0008MB-R3 for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 02:21:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOtnK-0003ne-IR for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 02:21:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=yZzVyMsSxf14Ha7Q2f3GPeolQ0FL9hJKH8hs/TDPOXk=; b=hUcPB/shTJd/6cRB9qqXqtcJt78TIK94iM+wYp0/OkpM/3Ud/amdC1DobEpSjoig4Pb+4AYIib2sOBcbA1F2q8suK5ggCgGpr6V6g04Vy+s0Zg6kn298iK/ie0+lXJziW0s+4ImiF4/2hdHsMhYCyiPEQjqrH/BU7NGUkgdCzyEVBfVCAsQMU2mQWkldPlhNzcnUU3t5EueST/NpqYrVMCHxhv/wGQnQDjETsguov8Lc4ZoQ1xQ8c6gDipqoLFh6mkh/BDhZu3cubh1nc5eXoxhtZTnlaJ56qXbphpPx1cEX0SJU970fRScG4K9OTEDxfJM9TAHA9PKXq8/bHY/ceA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOtnK-00017v-Cu for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 02:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2024 07:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74983-submit@debbugs.gnu.org id=B74983.17347656474293 (code B ref 74983); Sat, 21 Dec 2024 07:21:02 +0000 Original-Received: (at 74983) by debbugs.gnu.org; 21 Dec 2024 07:20:47 +0000 Original-Received: from localhost ([127.0.0.1]:45049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOtn5-00017A-7x for submit@debbugs.gnu.org; Sat, 21 Dec 2024 02:20:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOtn2-00016s-QU; Sat, 21 Dec 2024 02:20:45 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOtmx-0003k6-EW; Sat, 21 Dec 2024 02:20:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yZzVyMsSxf14Ha7Q2f3GPeolQ0FL9hJKH8hs/TDPOXk=; b=O6es5nZYM3xs lM/dDeVeyVFMxKbYwmyYUjMObRzkWpnYQ66e7CxIr53AfDYmEvQKYPDnuyGAN8ysRq51dfLyPkW2B T2hrRHS85NJlWzV+3R8Up6b4EQtsI8ADdw2ADz188T6X3BxQEiXChzW13KSgunGpFZ8G4Hx/wzWt/ jLaUaIL5XXfj6bkTn6xEkfE5/sTNIKnc+1sSpuShxn6rNfG1VMHvDrSm5xxEOTrmh+OqOnqmVNWFh Q1mDCRZbOT7AzCGXx5b5prRojPv2u3xvPmT3v6TQrOCb4FYozh1Hd6NVQj1BGrQCFfYjXFvZ8OuHg +cQNwGTHPAevgT7cj4Uxrw==; In-Reply-To: <877c7u58iw.fsf@topbug.net> (message from Hong Xu on Fri, 20 Dec 2024 13:50:15 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297491 Archived-At: merge 74983 74999 thanks > From: Hong Xu > Cc: Stefan Kangas , 74983@debbugs.gnu.org > Date: Fri, 20 Dec 2024 13:50:15 -0800 > > On 2024-12-19 Thu 23:01 GMT-08, Eli Zaretskii wrote: > > >> From: Hong Xu > >> Date: Thu, 19 Dec 2024 14:36:29 -0800 > >> > >> * Since `define-key' is considered legacy and we encourage `keymap-set' > >> now. > > > > Thanks. But the second chunk is not really right, since we have many > > more define-key there than keymap-set. > > > > So my suggestion is not to _replace_ define-key with keymap-set, but > > instead describe _both_, explaining that as of Emacs 29 we are > > migrating towards keymap-set, which is preferred. > > Thanks, I agree. I've made a followup patch. For some reason the > followup patch didn't attach to the Message ID of this thread and a new > bug 74999 was created. I've now merged them.