bug#3148: 23.0.91; spam.el uses query-dns instead of dns-query

bug#3148: 23.0.91; spam.el uses query-dns instead of dns-query

[Magnus Henoch]

lisp/gnus/spam.el autoloads and uses `query-dns' from dns.el, but that
function was renamed `dns-query' a while ago.

Magnus

bug#3148: 23.0.91; spam.el uses query-dns instead of dns-query

[Reiner Steib]

On Tue, Apr 28 2009, Magnus Henoch wrote:

> lisp/gnus/spam.el autoloads and uses `query-dns' from dns.el, but that
> function was renamed `dns-query' a while ago.

Fixed in CVS.  Thanks for the report.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

bug#3148: marked as done (23.0.91; spam.el uses query-dns instead of dns-query)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]


Your message dated Tue, 28 Apr 2009 18:59:54 +0200
with message-id <87eivcbto5.fsf@marauder.physik.uni-ulm.de>
and subject line Re: bug#3148: 23.0.91; spam.el uses query-dns instead of dns-query
has caused the Emacs bug report #3148,
regarding 23.0.91; spam.el uses query-dns instead of dns-query
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3148: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3148
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2216 bytes --]

From: Magnus Henoch <magnus@erlang-consulting.com>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.91; spam.el uses query-dns instead of dns-query
Date: Tue, 28 Apr 2009 16:38:21 +0100
Message-ID: <843absss9e.fsf@linux-b2a3.site>

lisp/gnus/spam.el autoloads and uses `query-dns' from dns.el, but that
function was renamed `dns-query' a while ago.

Magnus



[-- Attachment #3: Type: message/rfc822, Size: 2418 bytes --]

From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Magnus Henoch <magnus@erlang-consulting.com>
Cc: 3148@emacsbugs.donarmstrong.com, 3148-done@emacsbugs.donarmstrong.com
Subject: Re: bug#3148: 23.0.91; spam.el uses query-dns instead of dns-query
Date: Tue, 28 Apr 2009 18:59:54 +0200
Message-ID: <87eivcbto5.fsf@marauder.physik.uni-ulm.de>

On Tue, Apr 28 2009, Magnus Henoch wrote:

> lisp/gnus/spam.el autoloads and uses `query-dns' from dns.el, but that
> function was renamed `dns-query' a while ago.

Fixed in CVS.  Thanks for the report.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: bug#3148: 23.0.91; spam.el uses query-dns instead of dns-query

[Ted Zlatanov]

On Tue, 28 Apr 2009 18:59:54 +0200 Reiner Steib <reinersteib+gmane@imap.cc> wrote: 

RS> On Tue, Apr 28 2009, Magnus Henoch wrote:
>> lisp/gnus/spam.el autoloads and uses `query-dns' from dns.el, but that
>> function was renamed `dns-query' a while ago.

RS> Fixed in CVS.  Thanks for the report.

This is a good indication no one uses that feature, so would it be
better to just remove it?  Magnus, did you actually use it or just
notice the problem?

Ted

bug#3148: 23.0.91; spam.el uses query-dns instead of dns-query

[Magnus Henoch]

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Tue, 28 Apr 2009 18:59:54 +0200 Reiner Steib <reinersteib+gmane@imap.cc> wrote: 
>
> RS> On Tue, Apr 28 2009, Magnus Henoch wrote:
>>> lisp/gnus/spam.el autoloads and uses `query-dns' from dns.el, but that
>>> function was renamed `dns-query' a while ago.
>
> RS> Fixed in CVS.  Thanks for the report.
>
> This is a good indication no one uses that feature, so would it be
> better to just remove it?  Magnus, did you actually use it or just
> notice the problem?

I didn't actually use it.  I noticed because jabber.el tries first
query-dns, and then dns-query:

(if (fboundp 'query-dns)
    (query-dns target 'SRV t)
  (dns-query target 'SRV t))

If the broken autoload for query-dns was loaded, it would try to use it
and fail.

Magnus