From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Crash at startup in Cygwin w32 build on emacs-25 branch Date: Sat, 28 Nov 2015 21:18:07 +0000 Message-ID: <86vb8lu8kw.fsf@gmail.com> References: <86bnagfgf7.fsf@gmail.com> <83d1uvuawp.fsf@gnu.org> <86oaef2eiw.fsf@gmail.com> <83d1uur0zo.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448745534 17763 80.91.229.3 (28 Nov 2015 21:18:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Nov 2015 21:18:54 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 28 22:18:40 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a2mtE-0007gX-1B for ged-emacs-devel@m.gmane.org; Sat, 28 Nov 2015 22:18:40 +0100 Original-Received: from localhost ([::1]:33827 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2mtH-00024V-Ii for ged-emacs-devel@m.gmane.org; Sat, 28 Nov 2015 16:18:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2mtE-00024Q-CK for emacs-devel@gnu.org; Sat, 28 Nov 2015 16:18:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2mt9-0005oA-Ey for emacs-devel@gnu.org; Sat, 28 Nov 2015 16:18:40 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:45091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2mt9-0005o6-7j for emacs-devel@gnu.org; Sat, 28 Nov 2015 16:18:35 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1a2msw-00077j-06 for emacs-devel@gnu.org; Sat, 28 Nov 2015 22:18:22 +0100 Original-Received: from 82-69-64-228.dsl.in-addr.zen.co.uk ([82.69.64.228]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 28 Nov 2015 22:18:21 +0100 Original-Received: from andrewjmoreton by 82-69-64-228.dsl.in-addr.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 28 Nov 2015 22:18:21 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 24 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 82-69-64-228.dsl.in-addr.zen.co.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (windows-nt) Cancel-Lock: sha1:4XIAzcOG3zop7gOjelwj7F1olCg= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195490 Archived-At: On Sat 28 Nov 2015, Eli Zaretskii wrote: >> From: Andy Moreton >> It may be safer to provide the thread ID from a function to ensure >> that it has been initialised before callers try to use it. > > Not sure what you mean here. Do you mean use an accessor instead of a > global variable? If so, I don't understand the rationale. I meant an accessor, to ensure that users of dwMainThreadId don't use it uninitialised, which is not necessarily easy to spot for all of the combiations of build options. Probably not worth the bother though. >> > Btw, it's high time you got write access to the repository. Would you >> > like that? >> >> That would prbably make sense. What needs to be done to arrange that ? > > Get a Savannah account (http://savannah.gnu.org/account/register.php, > I believe), then apply for membership in the Emacs project. ok, will do. AndyM