From: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
To: Robert Pluim <rpluim@gmail.com>
Cc: 40343@debbugs.gnu.org
Subject: bug#40343: 28.0.50; dns-set-servers fails on IPv6 available Windows
Date: Tue, 31 Mar 2020 23:22:33 +0900 [thread overview]
Message-ID: <86v9mkmwnq.wl--xmue@d1.dion.ne.jp> (raw)
In-Reply-To: <m2zhbw3cha.fsf@gmail.com>
> Does this work for you:
>
> diff --git a/lisp/net/dns.el b/lisp/net/dns.el
> index 78d4827162..fd2ea99ac6 100644
> --- a/lisp/net/dns.el
> +++ b/lisp/net/dns.el
> @@ -328,7 +328,7 @@ dns-set-servers
> (call-process "nslookup" nil t nil "localhost")
> (goto-char (point-min))
> (re-search-forward
> - "^Address:[ \t]*\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" nil t)
> + "^Address:[ \t]*\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)\\|\\([[:xdigit:]:]*\\)" nil t)
> (setq dns-servers (list (match-string 1))))))
> (when (fboundp 'network-interface-list)
> (setq dns-servers-valid-for-interfaces (network-interface-list))))
I needed to modify your regexp as below. Additionally, I have
question that whether we should consider the case nslookup doesn't
return DNS server address, i.e. the case that re-search-forward didn't
match anything. In that case, (match-string 1) at next line returns
inconstant value. But according to docstring of dns-set-servers,
dns-servers should be set to nil.
diff --git a/lisp/net/dns.el b/lisp/net/dns.el
index 78d4827162..92db9a5bac 100644
--- a/lisp/net/dns.el
+++ b/lisp/net/dns.el
@@ -328,7 +328,7 @@ dns-set-servers
(call-process "nslookup" nil t nil "localhost")
(goto-char (point-min))
(re-search-forward
- "^Address:[ \t]*\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" nil t)
+ "^Address:[ \t]*\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\|[[:xdigit:]:]*\\)" nil t)
(setq dns-servers (list (match-string 1))))))
(when (fboundp 'network-interface-list)
(setq dns-servers-valid-for-interfaces (network-interface-list))))
--
Kazuhiro Ito
next prev parent reply other threads:[~2020-03-31 14:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 8:46 bug#40343: 28.0.50; dns-set-servers fails on IPv6 available Windows Kazuhiro Ito
2020-03-31 9:50 ` Robert Pluim
2020-03-31 11:06 ` Kazuhiro Ito
2020-03-31 13:01 ` Robert Pluim
2020-03-31 14:22 ` Kazuhiro Ito [this message]
2020-03-31 14:28 ` Robert Pluim
2020-04-01 13:43 ` Kazuhiro Ito
2020-04-01 13:57 ` Robert Pluim
2020-04-01 14:55 ` Kazuhiro Ito
2020-04-03 8:42 ` Robert Pluim
2020-04-03 14:08 ` Kazuhiro Ito
2020-04-03 15:19 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v9mkmwnq.wl--xmue@d1.dion.ne.jp \
--to=kzhr@d1.dion.ne.jp \
--cc=40343@debbugs.gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.