From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#45303: #45303 [feature/native-comp] building error on Windows Date: Mon, 21 Dec 2020 00:53:40 +0000 Message-ID: <86v9cw5697.fsf@gmail.com> References: <83k0te6c7i.fsf@gnu.org> <86im8w4t7y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6530"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) To: 45303@debbugs.gnu.org Cancel-Lock: sha1:dTDMxsvV1AWF2ZZR4IFZ165Ws0c= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 21 01:58:08 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kr9WZ-0001bf-Ag for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Dec 2020 01:58:07 +0100 Original-Received: from localhost ([::1]:32816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kr9WY-0003oZ-8t for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Dec 2020 19:58:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr9Sc-00070T-2F for bug-gnu-emacs@gnu.org; Sun, 20 Dec 2020 19:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kr9Sb-0005QK-Pu for bug-gnu-emacs@gnu.org; Sun, 20 Dec 2020 19:54:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kr9Sb-0001iS-Me for bug-gnu-emacs@gnu.org; Sun, 20 Dec 2020 19:54:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Dec 2020 00:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45303 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16085120326581 (code B ref -1); Mon, 21 Dec 2020 00:54:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Dec 2020 00:53:52 +0000 Original-Received: from localhost ([127.0.0.1]:45830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr9SS-0001i4-IN for submit@debbugs.gnu.org; Sun, 20 Dec 2020 19:53:52 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:42324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr9SR-0001hv-Bj for submit@debbugs.gnu.org; Sun, 20 Dec 2020 19:53:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr9SR-0006nU-2p for bug-gnu-emacs@gnu.org; Sun, 20 Dec 2020 19:53:51 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:40030) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr9SP-0005Lv-KN for bug-gnu-emacs@gnu.org; Sun, 20 Dec 2020 19:53:50 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1kr9SM-0007eT-9y for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 01:53:46 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196512 Archived-At: On Sun 20 Dec 2020, Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > > [...] > >> Thanks, hope 18ca9ea08a fix it. > ^^^^^ > 3bb2fd0c58 Thanks Andrea, that problem is fixed. There are still some warnings from comp.c that indicate other troubles: C:/emacs/git/emacs/native/src/comp.c: In function 'Fcomp__compile_ctxt_to_file': C:/emacs/git/emacs/native/src/comp.c:4461:12: warning: unused variable 'oldset' [-Wunused-variable] 4461 | sigset_t oldset; | ^~~~~~ C:/emacs/git/emacs/native/src/comp.c: In function 'eln_load_path_final_clean_up': C:/emacs/git/emacs/native/src/comp.c:4626:12: warning: passing argument 7 of 'internal_condition_case_5' from incompatible pointer type [-Wincompatible-pointer-types] 4626 | Qt, return_nil, Qnil); | ^~~~~~~~~~ | | | struct Lisp_X * (*)(struct Lisp_X *) In file included from C:/emacs/git/emacs/native/src/comp.c:23: C:/emacs/git/emacs/native/src/lisp.h:4161:195: note: expected 'Lisp_Object' {aka 'struct Lisp_X *'} but argument is of type 'struct Lisp_X * (*)(struct Lisp_X *)' 4161 | extern Lisp_Object internal_condition_case_5 (Lisp_Object (*) (Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object), Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object (*) (Lisp_Object)); | ^~~~~~~~~~~ In file included from C:/emacs/git/emacs/native/src/lisp.h:944, from C:/emacs/git/emacs/native/src/comp.c:23: ./globals.h:6980:14: warning: passing argument 8 of 'internal_condition_case_5' from incompatible pointer type [-Wincompatible-pointer-types] 6980 | #define Qnil builtin_lisp_symbol (0) | ^~~~~~~~~~~~~~~~~~~~~~~ | | | Lisp_Object {aka struct Lisp_X *} C:/emacs/git/emacs/native/src/comp.c:4626:24: note: in expansion of macro 'Qnil' 4626 | Qt, return_nil, Qnil); | ^~~~ In file included from C:/emacs/git/emacs/native/src/comp.c:23: C:/emacs/git/emacs/native/src/lisp.h:4161:208: note: expected 'struct Lisp_X * (*)(struct Lisp_X *)' but argument is of type 'Lisp_Object' {aka 'struct Lisp_X *'} 4161 | extern Lisp_Object internal_condition_case_5 (Lisp_Object (*) (Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object), Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object (*) (Lisp_Object)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The internal_condition_case_5 usage looks like the last two arguments might be swapped. The return_nil function is also declared as a nested function: that is a gcc extension, so it is more portable to define it as an ordinary static function. AndyM