From: Stephen Leake <stephen_leake@stephe-leake.org>
To: 48535@debbugs.gnu.org
Subject: bug#48535: 28.0.50; ff-find-other-file no longer sets current-buffer?
Date: Fri, 21 May 2021 14:09:44 -0700 [thread overview]
Message-ID: <86v97byesn.fsf_-_@stephe-leake.org> (raw)
In-Reply-To: <handler.48535.B.162151612728412.ack@debbugs.gnu.org> (GNU bug Tracking System's message of "Thu, 20 May 2021 13:09:02 +0000")
This breaks emacs ada-mode automated tests, which rely on evaluating
elisp forms in Ada comments.
git bisect says this commit is to blame:
commit: c105017c44d4a679f7af739b2c0390b2c7850569
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Tue Apr 6 17:06:07 2021 -0400
* lisp/find-file.el: Make the commands oblivious to mouse/non-mouse
(ff-find-other-file): Add `event` argument.
(ff-find-other-file-other-window): Rename from
`ff-mouse-find-other-file-other-window` and use this new argument.
(ff-mouse-find-other-file, ff-mouse-find-other-file-other-window):
Make them obsolete aliases.
(ff-upcase-p): Remove unused `start` and `end` arguments and
simplify accordingly.
I looked thru the diff, but I didn't see anything obvious, so I'm
blaming the lexical-binding change. But I don't know how to fix it.
I've confirmed that disabling lexical-binding fixes the problem.
--
-- Stephe
next prev parent reply other threads:[~2021-05-21 21:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 13:08 bug#48535: 28.0.50; ff-find-other-file no longer sets current-buffer? Stephen Leake
[not found] ` <handler.48535.B.162151612728412.ack@debbugs.gnu.org>
2021-05-21 21:09 ` Stephen Leake [this message]
2021-05-21 21:27 ` Stephen Leake
2021-05-23 15:57 ` Stephen Leake
2021-05-23 21:18 ` Stephen Leake
2021-05-23 21:56 ` Stephen Leake
2021-05-25 20:26 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v97byesn.fsf_-_@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=48535@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.