bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Arash Esbati]

Hi all,

I get this with master (f80fd099fc):

--8<---------------cut here---------------start------------->8---
  ELC+ELN  ../lisp/international/mule-cmds.elc

In end of data:
mule-cmds.el:3268:21: Warning: the function `emoji-list' is not known to be
    defined.
mule-cmds.el:3267:21: Warning: the function `emoji-recent' is not known to be
    defined.
mule-cmds.el:3266:21: Warning: the function `emoji-describe' is not known to
    be defined.
mule-cmds.el:3265:21: Warning: the function `emoji-search' is not known to be
    defined.
mule-cmds.el:3263:21: Warning: the function `emoji-insert' is not known to be
    defined.
--8<---------------cut here---------------end--------------->8---

I think after 6b706b1a7d, requiring the emoji library is necessary.

Best, Arash

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Date: Sun, 07 Nov 2021 09:37:24 +0100
> 
> I get this with master (f80fd099fc):
> 
> --8<---------------cut here---------------start------------->8---
>   ELC+ELN  ../lisp/international/mule-cmds.elc
> 
> In end of data:
> mule-cmds.el:3268:21: Warning: the function `emoji-list' is not known to be
>     defined.
> mule-cmds.el:3267:21: Warning: the function `emoji-recent' is not known to be
>     defined.
> mule-cmds.el:3266:21: Warning: the function `emoji-describe' is not known to
>     be defined.
> mule-cmds.el:3265:21: Warning: the function `emoji-search' is not known to be
>     defined.
> mule-cmds.el:3263:21: Warning: the function `emoji-insert' is not known to be
>     defined.
> --8<---------------cut here---------------end--------------->8---
> 
> I think after 6b706b1a7d, requiring the emoji library is necessary.

I guess you didn't bootstrap?  If so, just touch mule-cmds.el and try
again.

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Arash Esbati]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Arash Esbati <arash@gnu.org>
>> Date: Sun, 07 Nov 2021 09:37:24 +0100
>> 
>> I think after 6b706b1a7d, requiring the emoji library is necessary.
>
> I guess you didn't bootstrap?  If so, just touch mule-cmds.el and try
> again.

I use a script which does:

    git clean -fdx && ./autogen.sh && ./configure ... && make

My tree should be then in a clean status when make starts.

I also tried your suggestion, warnings remain.

Best, Arash

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: 51654@debbugs.gnu.org
> Date: Sun, 07 Nov 2021 12:03:07 +0100
> 
> > I guess you didn't bootstrap?  If so, just touch mule-cmds.el and try
> > again.
> 
> I use a script which does:
> 
>     git clean -fdx && ./autogen.sh && ./configure ... && make
> 
> My tree should be then in a clean status when make starts.
> 
> I also tried your suggestion, warnings remain.

There should be a file lisp/international/emoji.el, where this command
is defined.  Do you have that file?

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Lars Ingebrigtsen]

Arash Esbati <arash@gnu.org> writes:

> In end of data:
> mule-cmds.el:3268:21: Warning: the function `emoji-list' is not known to be
>     defined.

You need to say "cd lisp; make autoloads-force" until the ldefs-boot
changes have been pushed (which usually happens once a week).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Arash Esbati]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Arash Esbati <arash@gnu.org>
>> Cc: 51654@debbugs.gnu.org
>> Date: Sun, 07 Nov 2021 12:03:07 +0100
>> 
>> > I guess you didn't bootstrap?  If so, just touch mule-cmds.el and try
>> > again.
>> 
>> I use a script which does:
>> 
>>     git clean -fdx && ./autogen.sh && ./configure ... && make
>> 
>> My tree should be then in a clean status when make starts.
>> 
>> I also tried your suggestion, warnings remain.
>
> There should be a file lisp/international/emoji.el, where this command
> is defined.  Do you have that file?

,----[ C-h f emoji-insert RET ]
| emoji-insert is an autoloaded interactive Lisp closure in ‘emoji.el’.
| 
| It is bound to C-x 8 e i, C-x 8 e e.
| 
| (emoji-insert &optional TEXT)
| 
| Choose and insert an emoji glyph.
| If TEXT (interactively, the prefix), use a textual search instead
| of a visual interface.
| 
|   Probably introduced at or before Emacs version 29.1.
| 
`----

Best, Arash

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: 51654@debbugs.gnu.org
> Date: Sun, 07 Nov 2021 14:23:47 +0100
> 
> > There should be a file lisp/international/emoji.el, where this command
> > is defined.  Do you have that file?
> 
> ,----[ C-h f emoji-insert RET ]
> | emoji-insert is an autoloaded interactive Lisp closure in ‘emoji.el’.

And what does loaddefs.el say about emoji-insert.

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> And what does loaddefs.el say about emoji-insert.

Like I said, ldefs-boot.el hasn't been updated yet, so Emacs doesn't know
about these autoloads in a normal build.  You have to say "make
autoloads-force" in these situations.

(Or we could push updates to ldefs-boot.el when we push new
;;;###autoloads, but the last time I did that, there were some angry
people.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Arash Esbati <arash@gnu.org>,  51654@debbugs.gnu.org
> Date: Sun, 07 Nov 2021 14:36:02 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > And what does loaddefs.el say about emoji-insert.
> 
> Like I said, ldefs-boot.el hasn't been updated yet, so Emacs doesn't know
> about these autoloads in a normal build.

Doesn't the bootstrap rebuild loaddefs.el from scratch?

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Arash Esbati]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Arash Esbati <arash@gnu.org>
>> Cc: 51654@debbugs.gnu.org
>> Date: Sun, 07 Nov 2021 14:23:47 +0100
>> 
>> > There should be a file lisp/international/emoji.el, where this command
>> > is defined.  Do you have that file?
>> 
>> ,----[ C-h f emoji-insert RET ]
>> | emoji-insert is an autoloaded interactive Lisp closure in ‘emoji.el’.
>
> And what does loaddefs.el say about emoji-insert.

loaddefs.el is under

    z:/pathto/emacs/share/emacs/29.0.50/lisp/loaddefs.el

and says:

    ;;;### (autoloads nil "emoji" "international/emoji.el" (0 0 0 0))
    ;;; Generated autoloads from international/emoji.el

    (autoload 'emoji-insert "emoji" "\
    Choose and insert an emoji glyph.
    If TEXT (interactively, the prefix), use a textual search instead
    of a visual interface.

    \(fn &optional TEXT)" t nil)

    (autoload 'emoji-recent "emoji" "\
    Choose and insert a recently used emoji glyph." t nil)

    (autoload 'emoji-search "emoji" "\
    Choose and insert an emoji glyph by searching for an emoji name." t nil)

    (autoload 'emoji-list "emoji" "\
    List emojis and insert the one that's selected.
    The character will be inserted into the buffer that was selected
    when the command was issued." t nil)

    (autoload 'emoji-describe "emoji" "\
    Say what the name of the composed grapheme cluster GLYPH is.
    If it's not known, this function returns nil.

    Interactively, it will message what the name of the emoji (or
    character) under point is.

    \(fn GLYPH &optional INTERACTIVE)" t nil)

    (register-definition-prefixes "emoji" '("emoji-"))

Best, Arash

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> Like I said, ldefs-boot.el hasn't been updated yet, so Emacs doesn't know
>> about these autoloads in a normal build.
>
> Doesn't the bootstrap rebuild loaddefs.el from scratch?

Unfortunately not -- I assumed that was by design?  (Since it's pretty
slow.)  If I remember correctly, it just copies over ldefs-boot.el to
loaddefs.el.  (But it's been a couple of months since I looked at this
last time, so I may be misremembering.)

But if we could fix that, then we'd avoid all these transient glitches,
so I'd be for it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Arash Esbati]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> Like I said, ldefs-boot.el hasn't been updated yet, so Emacs doesn't know
>>> about these autoloads in a normal build.
>>
>> Doesn't the bootstrap rebuild loaddefs.el from scratch?
>
> Unfortunately not -- I assumed that was by design?  (Since it's pretty
> slow.)  If I remember correctly, it just copies over ldefs-boot.el to
> loaddefs.el.  (But it's been a couple of months since I looked at this
> last time, so I may be misremembering.)
>
> But if we could fix that, then we'd avoid all these transient glitches,
> so I'd be for it.

I'm not familiar with Emacs internals during the build process, but
depending on how slow this is, I think this is useful change.  It is
somewhat misleading to get warnings with a fresh clone because one file
gets updated once a week or so.

Best, Arash

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> (But it's been a couple of months since I looked at this
> last time, so I may be misremembering.)

I think I did misremember.

The ldefs-boot is used before dumping Emacs -- and mule-cmds is
preloaded.  Afterwards autoloads.el is built and contains the correct
information.

So we'll get this warning until an ldefs-boot.el update is pushed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51654: 29.0.50; mule-cmds.el compiler warnings about emoji-*

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I think I did misremember.
>
> The ldefs-boot is used before dumping Emacs -- and mule-cmds is
> preloaded.  Afterwards autoloads.el is built and contains the correct
> information.
>
> So we'll get this warning until an ldefs-boot.el update is pushed.

So I don't think there's anything here to fix (unless it's pushing
ldefs-boot.el changes more often), and I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no