From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Finalizing 'inhibit-automatic-native-compilation' Date: Sat, 28 Jan 2023 21:41:06 +0000 Message-ID: <86v8kqpcb1.fsf@gmail.com> References: <837cx8cey0.fsf@gnu.org> <83357vauh5.fsf@gnu.org> <837cx6a8me.fsf@gnu.org> <83357ua6ja.fsf@gnu.org> <83zga28ra8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9484"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:fyltOooWzCOfitIuuTmaVhYl8pc= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 29 07:06:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pM0pr-0002HD-S3 for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Jan 2023 07:06:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pM0pK-0004EP-C9; Sun, 29 Jan 2023 01:06:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLswo-0003CV-Iy for emacs-devel@gnu.org; Sat, 28 Jan 2023 16:41:18 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLswm-0003z4-QX for emacs-devel@gnu.org; Sat, 28 Jan 2023 16:41:17 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pLswj-0002Zf-8E for emacs-devel@gnu.org; Sat, 28 Jan 2023 22:41:13 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.15, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 29 Jan 2023 01:06:03 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302738 Archived-At: On Sat 28 Jan 2023, Eli Zaretskii wrote: >> From: Stefan Monnier >> Cc: emacs-devel@gnu.org, akrl@sdf.org, larsi@gnus.org, rlb@defaultvalue.org >> Date: Sat, 28 Jan 2023 13:00:48 -0500 >> >> >> And we do have a solution: pregenerate the trampolines. >> > So you are saying that the "prevent writing trampolines" part of >> > inhibit-automatic-native-compilation is not needed? >> >> I'm saying it's only needed temporarily, until we fix our compilation >> system so trampolines are pregenerated. > > Can we decide that "temporarily" we will write trampolines even if > native-compilation was disabled, i.e. go back to what we had in Emacs > 28? `comp-enable-subr-trampolines' is also relevant. In bug #60996 Windows builds currently error on delete-file for a trampoline .eln file if inhibit-automatic-native-compilation is non-nil (because Windows does not allow the .eln file to be deleted while it is loaded as a DLL). If inhibit-automatic-native-compilation is non-nil and comp-enable-subr-trampolines is nil then the delete-file error is avoided (at a cost of losing correct handling of advised primitives). AndyM