From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69493: 30.0.50; Preferable choice of coding system on Japanese Date: Sat, 02 Mar 2024 09:07:06 +0200 Message-ID: <86v865p0x1.fsf@gnu.org> References: <85y1b134av.wl--xmue@d1.dion.ne.jp> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23247"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69493-done@debbugs.gnu.org To: Kazuhiro Ito Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 02 08:08:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rgJTW-0005nt-AQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Mar 2024 08:08:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rgJT5-0000kd-Nh; Sat, 02 Mar 2024 02:07:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rgJT4-0000kJ-OX for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2024 02:07:34 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rgJT4-0002qs-GQ for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2024 02:07:34 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rgJTW-0000mP-MC for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2024 02:08:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Mar 2024 07:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 69493 X-GNU-PR-Package: emacs Mail-Followup-To: 69493@debbugs.gnu.org, eliz@gnu.org, kzhr@d1.dion.ne.jp Original-Received: via spool by 69493-done@debbugs.gnu.org id=D69493.17093632712972 (code D ref 69493); Sat, 02 Mar 2024 07:08:02 +0000 Original-Received: (at 69493-done) by debbugs.gnu.org; 2 Mar 2024 07:07:51 +0000 Original-Received: from localhost ([127.0.0.1]:37870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgJTK-0000lr-JF for submit@debbugs.gnu.org; Sat, 02 Mar 2024 02:07:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgJTJ-0000lf-6H for 69493-done@debbugs.gnu.org; Sat, 02 Mar 2024 02:07:49 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rgJSh-0002lg-4L; Sat, 02 Mar 2024 02:07:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7rCzBS1ONsOpwGR9rX7EmlzC8v+ehCnWJGmJFXdTc/8=; b=GsdPHDEWBM/k +f7ogoTMeIU0LiCnH4b8l9A2Blg/h6i81mI79apeWzCgTnoNZV84/5wJ3TD2N7rIrkLmg17jW4ysK hwJGTgH1HkxmcKS68KHrfzskTiJrOp7IawOr0dEkCEitclNkNfvV4izMAOt463OEq27F0YFmgQpY1 LKjtgxROJk1oombZ8YSB1Klxf10cUYtGfk/IdrLJewS9zD4vZpJOT45ibQldWghIedHYKqbnEvwF2 BMv0PtI0J+y47oiuqamrNaT67SZtsdMMMxK7p/EMWEONFiiXd43YLXUwiFX9VfFe9LtlupeZ/uEGq qqo5J8D7cHJFoBonhXECAQ==; In-Reply-To: <85y1b134av.wl--xmue@d1.dion.ne.jp> (message from Kazuhiro Ito on Sat, 02 Mar 2024 08:44:56 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280887 Archived-At: > Date: Sat, 02 Mar 2024 08:44:56 +0900 > From: Kazuhiro Ito > > When I call (set-language-environment "Japanese"), below code in > lisp/language/japan-util.el is called. > > (defun setup-japanese-environment-internal () > (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin)) > 'japanese-shift-jis > 'utf-8)) > (use-cjk-char-width-table 'ja_JP)) > > 1. japanese-shift-jis is not proper coding system on Cygwin. > 2. We have japanese-cp932, more appropriate coding system for DOS/Windows. > > PLease see below patch. Thanks, installed on the master branch, and closing the bug. P.S. Please in the future try to submit patches in the format produced by "git format-patch" -- that makes applying the patches much easier.