all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
Cc: 69493-done@debbugs.gnu.org
Subject: bug#69493: 30.0.50; Preferable choice of coding system on Japanese
Date: Sat, 02 Mar 2024 09:07:06 +0200	[thread overview]
Message-ID: <86v865p0x1.fsf@gnu.org> (raw)
In-Reply-To: <85y1b134av.wl--xmue@d1.dion.ne.jp> (message from Kazuhiro Ito on Sat, 02 Mar 2024 08:44:56 +0900)

> Date: Sat, 02 Mar 2024 08:44:56 +0900
> From: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
> 
> When I call (set-language-environment "Japanese"), below code in
> lisp/language/japan-util.el is called.
> 
> (defun setup-japanese-environment-internal ()
>   (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
> 			    'japanese-shift-jis
> 			  'utf-8))
>   (use-cjk-char-width-table 'ja_JP))
> 
> 1. japanese-shift-jis is not proper coding system on Cygwin.
> 2. We have japanese-cp932, more appropriate coding system for DOS/Windows.
> 
> PLease see below patch.

Thanks, installed on the master branch, and closing the bug.

P.S. Please in the future try to submit patches in the format produced
by "git format-patch" -- that makes applying the patches much easier.





      reply	other threads:[~2024-03-02  7:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 23:44 bug#69493: 30.0.50; Preferable choice of coding system on Japanese Kazuhiro Ito
2024-03-02  7:07 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86v865p0x1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=69493-done@debbugs.gnu.org \
    --cc=kzhr@d1.dion.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.