From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v5] Add support for colored and styled underlines on tty frames Date: Sun, 10 Mar 2024 19:45:01 +0200 Message-ID: <86v85uugki.fsf@gnu.org> References: <20240211180501.695192-1-mohkale@kisara.moe> <87bk8m1mq8.fsf@yahoo.com> <87wmqaf1oy.fsf@kisara.moe> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13015"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 62994@debbugs.gnu.org To: Mohsin Kaleem Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 10 18:45:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjNFC-0003B6-2K for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Mar 2024 18:45:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjNF5-0004LR-9p; Sun, 10 Mar 2024 13:45:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjNEp-0004Kt-ED for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 13:45:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjNEm-0004Gj-K0 for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 13:45:30 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rjNFJ-0008QD-Ja for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 13:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Mar 2024 17:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.171009274732352 (code B ref 62994); Sun, 10 Mar 2024 17:46:01 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 10 Mar 2024 17:45:47 +0000 Original-Received: from localhost ([127.0.0.1]:37833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjNF5-0008Pk-1j for submit@debbugs.gnu.org; Sun, 10 Mar 2024 13:45:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjNF2-0008PN-CM for 62994@debbugs.gnu.org; Sun, 10 Mar 2024 13:45:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjNEP-00048u-7O; Sun, 10 Mar 2024 13:45:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wOivX5U7c9FsRTZ843GW+lR3/D1oH62hk+P8XpLjmZM=; b=L2sW5fV4blCk 9GPsKi3ZdIv+weTm4dhLLzme0AVohOxQwVNd5zB20RTwHZE8Zd99MdU+sRhBY8uKWxIbCo8kNgdEe F3qlMpHhJWT7W02sKBfzGPnIqJ/bsKpnkbBtPKVrPCi4w0HT9RaSB2sazLIZVwWKwNt5IDfkIcOxD ocd9MwNFepEtvE2uZIQriraCKNSNVcH5kuX9xe1L4HOSADfL5E/T7js4otE5h8j4VoyxPmrcQM/me Wr6G6KBC2oLR7yPxF7agxSmTfR9s9yBePYGu/FIZxXVmIuHmB+WrQVWzZlAuD54+WkOeL98UEsfxg vOUb/Ehrzrk2tn2AuqNK5g==; In-Reply-To: <87wmqaf1oy.fsf@kisara.moe> (message from Mohsin Kaleem on Sun, 10 Mar 2024 17:15:25 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281419 Archived-At: > From: Mohsin Kaleem > Cc: 62994@debbugs.gnu.org, Eli Zaretskii > Date: Sun, 10 Mar 2024 17:15:25 +0000 > > Po Lu writes: > > > mohkale@kisara.moe writes: > > > >> ++++ > > > > Where's the documentation for this change? > > Referring to the pluses themselves? Or I might be misunderstanding? I > was trying to match the format of other records in this file. Many > headings seemed to be followed by a mix of +++ or --- so I thought it > was required? If not I'll just remove it. The "+++" thingy means the manuals were updated for this change, which is why Po Lu asked where are those updates. > > We prefer to punctuate sentences within NEWS headings. > > Added trailing period. > > > What about GUI frames? I don't want to see a display feature installed > > before it is also implemented for the likes of X. > > Is this absolutely necessary? Not absolutely necessary, but very much preferred. It is unheard of in Emacs to have some face attribute that is supported on TTY frames but not on GUI frames. > > Here you have evidently typed `M-x tabify' with a comment selected. Do > > not insert tabs by whatever means within the body of a comment, although > > it is best to indent the body itself with them, whenever possible. > > > > More indentation problems. > > I had thought `M-x tabify` was supposed to normalize this to the Emacs > code standards. No, you should mark the region and then press C-M-\.