From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70927: 30.0.50; track-changes assertion when shutting down eglot Date: Tue, 14 May 2024 09:14:18 +0300 Message-ID: <86v83gx6md.fsf@gnu.org> References: <871q65xsi6.fsf@stebalien.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29740"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70927@debbugs.gnu.org To: Steven Allen , Stefan Monnier , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 14 08:15:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6lRr-0007VL-GF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 May 2024 08:15:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6lRK-0005jq-EZ; Tue, 14 May 2024 02:15:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6lRG-0005i1-Qq for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 02:15:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6lRG-0002CY-GY for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 02:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s6lRG-0000JE-3z for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 02:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2024 06:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70927 X-GNU-PR-Package: emacs Original-Received: via spool by 70927-submit@debbugs.gnu.org id=B70927.17156672731154 (code B ref 70927); Tue, 14 May 2024 06:15:02 +0000 Original-Received: (at 70927) by debbugs.gnu.org; 14 May 2024 06:14:33 +0000 Original-Received: from localhost ([127.0.0.1]:37302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6lQn-0000IY-C9 for submit@debbugs.gnu.org; Tue, 14 May 2024 02:14:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6lQl-0000IO-5u for 70927@debbugs.gnu.org; Tue, 14 May 2024 02:14:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6lQe-0002A4-Rj; Tue, 14 May 2024 02:14:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=zUGFUHPBE8iG/3oc2ax3yo+/ynr64UP5c5JHmA3z5KA=; b=K/5K1+eEaFnNyEJJCAEs z8mQJjb7JK8V9Dv3yEiOMF0seGKmX0RAh2qrIQ6VMvb7fhGY1uuvxvzGOWrWjniuZoAmkl8s4PCUZ EY4npDO3a8qAGQLnQSGf/rTbYOS7L0CgWe4YcqbXertlmGrnvljDJBjh4l1KzgRZXx9/jf/Pl68UY p7p6hswIx5dYQTACjb7AXc+1IBJH+w/RLNvqzxG9o+I0hvvSXGdcrromJKPH7p+H85WLC7qKfpvL4 0BzFbuPNoISlRc6fTQ1ADgPT9IkkP93n6h0PAkw1X4llsD/X64SJ1HR86JH5eYJj5SabIjIZD21iA DTyG/ew5SrEJeg==; In-Reply-To: <871q65xsi6.fsf@stebalien.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284994 Archived-At: > Date: Mon, 13 May 2024 15:21:37 -0700 > From: Steven Allen via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > When `eglot-autoshutdown` is set, killing eglot buffers fails with a > track-changes assertion because, from what I can tell, > `eglot--signal-textDocument/didChange` is called when > `eglot--track-changes` is `nil`. > > Backtrace: > > cl--assertion-failed((memq id track-changes--trackers)) > track-changes-fetch(nil #) > eglot--track-changes-fetch(nil) > eglot--signal-textDocument/didChange() > eglot--request(# :shutdown nil :timeout 1.5) > eglot-shutdown(#) > eglot--managed-mode(-1) > eglot--managed-mode-off() > kill-current-buffer() > funcall-interactively(kill-current-buffer) > command-execute(kill-current-buffer) > > Reproduction: > > 1. Start emacs with `emacs -Q`. > 2. Run `M-: (setopt eglot-autoshutdown t) RET` > 3. Open any file you have an LSP server for and run `M-x eglot RET`. > 4. Kill the buffer. Thanks, I added Stefan and João to the discussion.