From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71355: 30.0.50; [PATCH] Improve performance of buffered output in Eshell Date: Wed, 05 Jun 2024 21:58:22 +0300 Message-ID: <86v82ni5dd.fsf@gnu.org> References: <22b0dc8f-11dc-5fd2-c75d-88c17580d28d@gmail.com> <848772e9-5ef0-8a8a-decd-c0b79366ec27@gmail.com> <86ikynk30i.fsf@gnu.org> <037ebce9-93af-f1ad-67d9-550fd1074294@gmail.com> <8634prjpt0.fsf@gnu.org> <9da5a395-48e8-fb20-145b-1d2581315fcf@gmail.com> <86y17ji860.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17842"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71355@debbugs.gnu.org, stefankangas@gmail.com To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 05 20:59:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEvqi-0004Na-Bs for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jun 2024 20:59:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEvqT-0007JO-No; Wed, 05 Jun 2024 14:58:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEvqS-0007HW-EO for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 14:58:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEvqS-0003qZ-6h for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 14:58:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEvqg-00028r-9S for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 14:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jun 2024 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71355 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71355-submit@debbugs.gnu.org id=B71355.17176139298193 (code B ref 71355); Wed, 05 Jun 2024 18:59:02 +0000 Original-Received: (at 71355) by debbugs.gnu.org; 5 Jun 2024 18:58:49 +0000 Original-Received: from localhost ([127.0.0.1]:57519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEvqS-000285-J8 for submit@debbugs.gnu.org; Wed, 05 Jun 2024 14:58:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEvqR-00027i-Dg for 71355@debbugs.gnu.org; Wed, 05 Jun 2024 14:58:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEvq7-0003mD-TF; Wed, 05 Jun 2024 14:58:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zSVYY1EB0B+kppH4qA5lCxKC8afQId5noNQ2m/CCPWU=; b=hfJ8mNhHI33t /ueIBMSQih98Dz4mZ0FeSPQjsRhicS2oknhAXv2ZGN/GyqDvhXWWvUx9KEJz56431wjjJxFgtCCef FwpsAnbgMQynBsZp7lk5wB9DEHGC0BWbjgEfWb+gZJ9zxUTrJr0lVWDfeRDmQ4o9YkUrCxq3HJNmF VWemAQMfY/LfIHzKgvCGyiHIibkOZyziAWaXzkTR2EhwkqjHNQ4A33RYN7N51N1mYj5uU2c98EqaI W2vs2qGEhENdK88SLCxpyYh5BbYoh51nFJDdOJqNI7fwB7Ifl+AWJuo89muQhLn5BKPEA9/HrhzSq aepyn/heIYkMyRjOpm4e/Q==; In-Reply-To: (message from Jim Porter on Wed, 5 Jun 2024 11:47:40 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286637 Archived-At: > Date: Wed, 5 Jun 2024 11:47:40 -0700 > Cc: 71355@debbugs.gnu.org, stefankangas@gmail.com > From: Jim Porter > > > But at least part of your patch calls redisplay > > after each chunk (AFAIU), something that is not done with the current > > code. So I expect the effect to be a difference in behavior, whereby > > test appears on the screen in chunks, and the user does not need to > > wait till all of it is sent before he/she sees anything at all > > displayed. > > Correct. The redisplay logic is a new behavior, and not *directly* a > part of the performance improvements I made by increasing the buffer > size. On the contrary, I added the redisplay logic because the buffer > size improvements made the total execution time so much better that I > felt Eshell could now afford the extra cost of redisplaying periodically > for these commands. So now that we agree about this aspect, I ask again: wouldn't it make sense to show the text to the user in smaller chunks? 2K characters is 2 dozen lines, and I expect users to be somewhat unhappy about being presented the text in such large chunks. That's now what they see when invoking 'cat' from the shell prompt outside Emacs.