From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72818: 29.4; Cannot hook with use-package if variable is not `-hook'$ Date: Sat, 31 Aug 2024 13:08:24 +0300 Message-ID: <86v7zhatt3.fsf@gnu.org> References: <87seurh7xe.fsf@telenieko.com> <86h6b7jz5k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13742"; mail-complaints-to="usenet@ciao.gmane.io" Cc: telenieko@telenieko.com, 72818-done@debbugs.gnu.org To: John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 31 12:09:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1skL2s-0003Nu-Oy for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Aug 2024 12:09:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1skL2Z-0007ta-27; Sat, 31 Aug 2024 06:09:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1skL2W-0007t9-KE for bug-gnu-emacs@gnu.org; Sat, 31 Aug 2024 06:09:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1skL2W-00015m-Bd for bug-gnu-emacs@gnu.org; Sat, 31 Aug 2024 06:09:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=+5B4/oOYDrev+kTIdCcS/36AcD8yW2lsSldVBqeYhfs=; b=r2pepmiUsuPcaiXobQoWLaTwhdgmLaVo1PtBk+uSmxHYiM1FEOlEf5wEgNbB5IzCUQpB45WvFjoxHAw5XAg9mJDC+YlZyCyU+/V1d15ZvA8jhzCu8roqjl2oS1hQ4/mXQAuN45FWh/2vpKLRk4r1ClgxVir3T/J9cdMZxKaZ6KAbxkgT2XiUALvQch9Guxw46SbrdiF9BaiTzmjQNvmyQ3mNvM8xdAF1OkT7VJj8TERzC+Bd2dal4S8Bw+z718mTnS/KgBpPEFChyDmK3fFyGGiht8BvbIMBFH0iWziEyEoiwBkD0/7FyWYfzGxUBRzFlRDY4zywqNa+VjEP3lteFw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1skL3S-0001W4-7x for bug-gnu-emacs@gnu.org; Sat, 31 Aug 2024 06:10:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Aug 2024 10:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72818 X-GNU-PR-Package: emacs Mail-Followup-To: 72818@debbugs.gnu.org, eliz@gnu.org, telenieko@telenieko.com Original-Received: via spool by 72818-done@debbugs.gnu.org id=D72818.17250989735777 (code D ref 72818); Sat, 31 Aug 2024 10:10:02 +0000 Original-Received: (at 72818-done) by debbugs.gnu.org; 31 Aug 2024 10:09:33 +0000 Original-Received: from localhost ([127.0.0.1]:53998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1skL2y-0001V6-VL for submit@debbugs.gnu.org; Sat, 31 Aug 2024 06:09:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1skL2w-0001Ur-Tq for 72818-done@debbugs.gnu.org; Sat, 31 Aug 2024 06:09:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1skL1u-00010G-Jh; Sat, 31 Aug 2024 06:08:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=+5B4/oOYDrev+kTIdCcS/36AcD8yW2lsSldVBqeYhfs=; b=OSBFBUdoAXnSIjBkhYtv rfbwvq7YxO7BRCv4m691PVs1UUXqdY+yDJ3xcsByHukxp1aRcUIEZT9IUCnToZslZ4tZEjRDX3Lny Al/VLLehGXyrcQtgTMYSB/cNddIEMOlPFFgntcg9Wz8xGOSN9tHGhb2Qw08OGkBfkYXJC+skIuOyD 83NFuUOEN60n1pDlBzwaIWVR7Vr2Z7DsApJvuV576oiok2BBOYsqx7T37bRYtUQPWEBA0PgKEZj2c yHLqoNmK7ryx3511f7AeTpQ/fwDIQaQAlFrkZzFfOEQwD/og6ugKhauK0T3BWpHQGieN1ogeoAGG1 YfVE69C3rCr1ag==; In-Reply-To: (message from John Wiegley on Mon, 26 Aug 2024 11:47:25 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291000 Archived-At: > From: John Wiegley > Cc: Marc Fargas , 72818@debbugs.gnu.org > Date: Mon, 26 Aug 2024 11:47:25 -0700 > > >>>>> Eli Zaretskii writes: > > > Maybe I'm missing something, but how can use-package configure > > abnormal hooks? It doesn't know which arguments to pass to them, > > right? > > > > John, am I missing something? > > I think the behavior should be that if the variable name exists at the time > the use-package macro is encountered, it should use it directly. Only if the > named hook variable has no ‘symbol-value’ — at that time — should it try > appending the name ‘-hook‘ to find a place to append the function. > > I.e., the definition could be: > > (defun use-package-handler/:hook (name _keyword args rest state) > "Generate use-package custom keyword code." > (use-package-concat > (use-package-process-keywords name rest state) > (cl-mapcan > #'(lambda (def) > (let ((syms (car def)) > (fun (cdr def))) > (when fun > (mapcar > #'(lambda (sym) > (if (boundp sym) > `(add-hook (quote ,sym) (function ,fun)) > `(add-hook > (quote ,(intern > (concat (symbol-name sym) > use-package-hook-name-suffix))) > (function ,fun)))) > (use-package-hook-handler-normalize-mode-symbols syms))))) > (use-package-normalize-commands args)))) Thanks, installed on the emacs-30 release branch, and closing the bug.