From: Eli Zaretskii <eliz@gnu.org>
To: Steven Allen <steven@stebalien.com>, John Wiegley <johnw@gnu.org>
Cc: 72993@debbugs.gnu.org
Subject: bug#72993: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package
Date: Tue, 03 Sep 2024 05:34:39 +0300 [thread overview]
Message-ID: <86v7zd79ds.fsf@gnu.org> (raw)
In-Reply-To: <87mskpo5qc.fsf@stebalien.com> (bug-gnu-emacs@gnu.org)
> Date: Mon, 02 Sep 2024 19:01:31 -0700
> From: Steven Allen via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
>
>
> In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, cairo version
> 1.18.0) of 2024-09-01 built on Laptop
> Repository revision: 92ea393a16e5c99a8860dab368c6ca3ca6abc3c5
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
> System Description: Arch Linux
>
> To reproduce:
>
> (use-package foo
> :hook (eshell-mode . some-function))
>
> Previously, `use-package' always appended `-hook' to the hook variable name.
> After 4f521fa14c18f57e5207bffd68e9f79454dccc79, `use-package' only does
> so if the passed variable name isn't bound. Unfortunately, this breaks
> binding mode hooks, e.g.:
>
> :hook (some-mode . some-function)
>
> Because `some-mode' is usually bound.
John, any comments or suggestions?
next prev parent reply other threads:[~2024-09-03 2:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 2:01 bug#72993: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-03 2:34 ` Eli Zaretskii [this message]
2024-09-03 4:37 ` John Wiegley
2024-09-03 12:38 ` Eli Zaretskii
2024-09-03 22:35 ` John Wiegley
2024-09-04 11:31 ` Eli Zaretskii
2024-09-04 17:30 ` John Wiegley
2024-09-04 17:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v7zd79ds.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72993@debbugs.gnu.org \
--cc=johnw@gnu.org \
--cc=steven@stebalien.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.