From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Accidental change of behaviour for electric-layout-mode? Date: Tue, 24 Sep 2024 14:23:57 +0300 Message-ID: <86v7yle1ma.fsf@gnu.org> References: <87wmj2dr4q.fsf@ice9.digital> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25342"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Morgan Willcock , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 24 13:24:40 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1st3ep-0006NY-Cm for ged-emacs-devel@m.gmane-mx.org; Tue, 24 Sep 2024 13:24:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1st3eF-0007Co-DO; Tue, 24 Sep 2024 07:24:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st3eD-0007Cb-Oq for emacs-devel@gnu.org; Tue, 24 Sep 2024 07:24:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st3eC-0004jJ-Sx; Tue, 24 Sep 2024 07:24:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xZ8cbjMh/DB0gyWDxXVK/sfrxnPuQnGk1vvKCmfusGk=; b=Neh2OCVXaytkg0SaN5FT Y6di3Ww2hbvX79SB2N89YONy+9aeMV1Mjr9366He6S/V86jadYFtB7fHh5/B1kDC8hMHdL4Okdyg4 wmNAIecsfv+voah8nl1PMDBa4x4capGC7aA2a26F9+3Guj184nuT+9c7NjMQwTvedmnHdekrYVZzs sTyp8YNTxc+Ydufz9eXNts37dUn9DWrSaGe1vj1YySzVHgsqWi3vIPHyBcNgNj+t1J1y+CS1I7q85 rkqHIdD8Ij4Kz7F8Nr0ezadpXW1l70pAhb9IMUcRlWL3PQE8NZ/RPePcHwbskFZRPf+rZNbGlCK5f kW1ut7WDZHZA7w==; In-Reply-To: <87wmj2dr4q.fsf@ice9.digital> (message from Morgan Willcock on Mon, 23 Sep 2024 21:58:13 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324018 Archived-At: > From: Morgan Willcock > Date: Mon, 23 Sep 2024 21:58:13 +0100 > > It looks like Emacs 30 is now allowing electric-layout-mode to insert > newlines inside comments and strings, whereas previous versions seem to > explicitly stop this from happening. > > The commit that does it is b1f8d98a119ab8845d25d80c480cde6e385d8749 > (Eglot: rework eglot-imenu) which doesn't mention electric-layout-mode > in the commit message or the associated bug report (58431). > > I think it may have been done accidentally and is likely not a backwards > compatible change. > > (I actually wanted the new behaviour and only found this because my > tests for newline insertion failed on Emacs 27, 28, and 29. Making the > new behaviour opt-in would be nice, so I could send a patch to do that > if the previous change does look to have been accidental.) João, was that change intentional, and if so, what was its reasons? Thanks.