From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Wed, 20 Nov 2024 14:54:10 +0200 Message-ID: <86v7wirrpp.fsf@gnu.org> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> <86ikskvie0.fsf@gnu.org> <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> <8634jov5ir.fsf@gnu.org> <86serntf0h.fsf@gnu.org> <05def9dc-c6bb-4b26-9f7e-8c26b25178c2@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38242"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 20 13:55:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDkEr-0009kp-81 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Nov 2024 13:55:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDkEb-0003s6-J6; Wed, 20 Nov 2024 07:55:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDkEa-0003rx-A0 for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 07:55:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDkEa-0001Ez-10 for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 07:55:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=Zcc6CBOKVrAClriOLGgW/iD/1afdCxPek3qNrthemhs=; b=deoZyLHwTs4mE+lJ/VG5p+sGL0WSWBCgpex1Ga4H0hAwyTCCnnk18AbIowp9ZIb2SZZNzOYemTHLj/BJZ5WFJ/c0dvbZ51XfHLvwnj6BiP/Yivx6naEzvMlc3dW1nJQ4auCe9Hw2QSZ32lNEd6SfmBA+RF5M1FCrFuhPWH+zkHf1A6M11qglJezv/8S7rqCNgG5MNwSjFxRCBfmuK8xMiLbqR7CJukQQNDzZTkSynI8QkTceR9v2YHQj+eBeAE9rn7hww5LjeNizgn0RPwEIGDe2cUBI8JT+PIkCKqlZWo9wAVXyDzAwmvGSaxnvnBV9E5whC9FggTZc5Q8xwMnhPQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDkEY-0002gv-RB for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 07:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2024 12:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173210726410265 (code B ref 74361); Wed, 20 Nov 2024 12:55:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 20 Nov 2024 12:54:24 +0000 Original-Received: from localhost ([127.0.0.1]:45748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDkDw-0002fU-FY for submit@debbugs.gnu.org; Wed, 20 Nov 2024 07:54:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDkDt-0002fE-TM for 74361@debbugs.gnu.org; Wed, 20 Nov 2024 07:54:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDkDm-0000kh-TG; Wed, 20 Nov 2024 07:54:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Zcc6CBOKVrAClriOLGgW/iD/1afdCxPek3qNrthemhs=; b=OOOgTi5vyn0N QLHE9hJpfYL6KD7VcYmebfCCDLJlBY6hDvYXMScpASKJt0IAX2jGh2wADq068ruW+o630nHXuc1rO AmLM0R/7pk+0j8Yt3mtAAUvVVQUYJ5bTiCu7ogOafeSbh/U4d4jE+1oez6qkBH7Qu7lA/e+PcJehE 3tbCO3WvN9gQD31gv9c54kMSeuyHlFaFiO1rd6S93yLv4GTqaQ0W/O3PPR7hDM0IL/4uDCrSgn+BL ANIQpijwMNuIQSA7Ds4k7BtqwT215AqGpj1fiecFsMM7lK9eBj+c2eZQJlT5mHYpj34afyudoao7q oEZRgRsBvy35pSBT0pG+sQ==; In-Reply-To: <05def9dc-c6bb-4b26-9f7e-8c26b25178c2@gutov.dev> (message from Dmitry Gutov on Tue, 19 Nov 2024 21:51:32 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295675 Archived-At: > Date: Tue, 19 Nov 2024 21:51:32 +0200 > Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > On 19/11/2024 17:33, Eli Zaretskii wrote: > >> Date: Tue, 19 Nov 2024 03:21:26 +0200 > >> Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net > >> From: Dmitry Gutov > >> > >> Next step is to find the appropriate place for it. Maybe not a docstring > >> if the user option to customize will be the global one > >> (display-buffer-alist), but either in Commentary or somewhere in the manual. > > > > Maybe just mention in the doc string that the commands use > > display-buffer to select the window? > > The important part is using a specific category, not just display-buffer. The doc string could mention the category as well. > And there doesn't seem to be a single docstring, or even a main > docstring to mention this in. There are at least 3 of them: > xref-find-definitions, xref-go-back and xref-go-forward, and these are > not the only ones affected. We have this situation elsewhere, and I personally simply copy/paste the same text into the doc strings. If the text is short enough, it works well IME.