From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 7c50e4cc8cc 2/2: Improve 'compilation-transform-file-match-alist' documentation Date: Wed, 04 Dec 2024 16:56:04 +0200 Message-ID: <86v7vzzed7.fsf@gnu.org> References: <173332205449.2846597.9153784089592444113@vcs3.savannah.gnu.org> <20241204142055.B1FEF5430D0@vcs3.savannah.gnu.org> <877c8feda3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23886"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 04 15:56:58 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIqoC-0005rn-V7 for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Dec 2024 15:56:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIqnS-0007Dw-GJ; Wed, 04 Dec 2024 09:56:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIqnQ-0007Dj-Pr for emacs-devel@gnu.org; Wed, 04 Dec 2024 09:56:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIqnQ-0002OO-IO; Wed, 04 Dec 2024 09:56:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Rssi70R2n5Tif0JRJG3O7S/VhTZ2Lfkue1KDAJyUQPM=; b=NQO+T+LO1pNbxoPq0aIp ZndALx3OhqaBoaYws7lODphHSJOleY0HSq2I7idmRsp4QEqEpxUsQENilOq6y7M3PgVql0C0EZDO2 MmQGkt0NdwPhG5w+/z1R7Y1hoEBLp/Bo2jIWcbuJGEIkqPQA2EoZD2mbSmyDD87y+Lplww6n+q/QA HAs133mtvYerbeD9DMz45EvfLUxGag6oyUHhhBwpf0SlxIwGjgKhSbx1bGFzap5mjd1wQSzScTbxP 4/++cOUnaTdq/a/swcdHA5+NQh6NdGxtz0IqWeNttV9H2c7LFtzNeDMXzDvQPFl3bCX20T/yJjqzG QodLCg1Y2IpDsw==; In-Reply-To: <877c8feda3.fsf@gmail.com> (message from Robert Pluim on Wed, 04 Dec 2024 15:25:08 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326030 Archived-At: > From: Robert Pluim > Date: Wed, 04 Dec 2024 15:25:08 +0100 > > >>>>> On Wed, 4 Dec 2024 09:20:55 -0500 (EST), Robert Pluim said: > > Robert> :type '(repeat (list regexp (choice (const :tag "No replacement" nil) > Robert> string))) > Robert> :version "27.1") > > I almost did the following as well on emacs-30, on the grounds that it > doesnʼt actually affect the real type of the user option, only the > display, but since I wasnʼt sure that was OK for the release branch I > thought Iʼd ask here. > > diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el > index ee7fc6aaecb..6a640a3c056 100644 > --- a/lisp/progmodes/compile.el > +++ b/lisp/progmodes/compile.el > @@ -77,8 +77,9 @@ compilation-transform-file-match-alist > Similarly, to remove a prefix \"bar/\", use: > > (\"\\\\=`bar/\" \"\")" > - :type '(repeat (list regexp (choice (const :tag "No replacement" nil) > - string))) > + :type '(repeat (list (regexp :tag "Match") > + (radio (const :tag "Not an error" nil) > + (string :tag "Replace with")))) > :version "27.1") I don't think I'd mind to install on emacs-30, but if we are doing this, why not do a better job? The tags above are not quite clear, to say the least. "Match"? "Replace with"? does that really explain itself? Thanks.