From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74700: [PATCH] Revert Dired buffer when clicking on last segment of directory name Date: Thu, 26 Dec 2024 14:08:40 +0200 Message-ID: <86v7v6y7cn.fsf@gnu.org> References: <874j3iodzb.fsf@gmail.com> <86ttbiy5na.fsf@gnu.org> <87zflamt6j.fsf@gmail.com> <8634it19cc.fsf@gnu.org> <87msgmozm3.fsf@web.de> <874j2tbw9j.fsf@gmail.com> <875xn8mz1d.fsf@web.de> <87r05w9xmo.fsf@gmail.com> <865xn6zusv.fsf@gnu.org> <87v7v6ek7g.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22988"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, 74700@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 26 13:12:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tQmiy-0005mM-BN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Dec 2024 13:12:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQmij-0006sN-QY; Thu, 26 Dec 2024 07:12:05 -0500 Original-Received: from [2001:470:142:3::10] (helo=eggs.gnu.org) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQmig-0006lS-Ri for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2024 07:12:03 -0500 Original-Received: from [2001:470:142:5::43] (helo=debbugs.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tQmig-0004SX-H8 for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2024 07:12:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=ePgay99YUh+StXmy5sgNGgrAlsMEHQ+Ox4ZIs08baTE=; b=u/AkbQcZ3D4SdLMPMXLPZ/ialbPaQ7taUv6dBB2ZH4kAdV2aD+xyz/YL3LNBSrbV8FaAh5Y+qjEvC5nzIoTozuGL3RXzeS/57tkJZQauakLSVy8R+VnIeCG2t9/wP6s7XUu+xz/AmWTlR/ZD4EeQGwlyfz0K/5QaNFpdNoG+in6NOn8MNfcrUAXTDkStIAFVpOTnYNRryiiBAJNwZ/LSC3EC/lSqjoGJsdn8mH8c3djjNZGbeoQ5c3FUpSNUVdZzt31gL8kVx149Eccd6nsywoVhtTyL7P8Fx4598bcCbdTiny4Cg/OultbGmzYIs9Vp2hkdpwh34Gp4AB7pKQXh7w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tQmig-0002o9-Be for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2024 07:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Dec 2024 12:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74700 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74700-submit@debbugs.gnu.org id=B74700.173521506210684 (code B ref 74700); Thu, 26 Dec 2024 12:12:02 +0000 Original-Received: (at 74700) by debbugs.gnu.org; 26 Dec 2024 12:11:02 +0000 Original-Received: from localhost ([127.0.0.1]:40371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQmhh-0002m8-U5 for submit@debbugs.gnu.org; Thu, 26 Dec 2024 07:11:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQmhe-0002lQ-6V for 74700@debbugs.gnu.org; Thu, 26 Dec 2024 07:10:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQmfT-0003rj-1W; Thu, 26 Dec 2024 07:08:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ePgay99YUh+StXmy5sgNGgrAlsMEHQ+Ox4ZIs08baTE=; b=d9UprCOtkzjPpuknl2iv tFc0I+r2gDQgIY74zQYvWxIN2+3P6QFdSuNotqE+OtMOgHnsYQFG0UrP+IY8233CWee7jw6RM0YuR Poiv31jJzU94cJHUeGJeYH+IC4gbHPyvtl2oY8VQ4s5BMkpU3ZzzFG0w8uIszTuWzV/up3p7X9XMx jRN/wM5wWXrm/15UjtK6gBEbglrINZay8Ndwy+tfn50uu/myVk9RqqRNENaeTu80KVAMiwVqbUCkl /7LrR6i+2Mc6TflsMzLOSsY+zZx55FtvHoxP8i2XKpvbwkL5S49rMEV8Ch12tMa1B/WTYrOZ4Jmz0 QMMop5hTvqIGYQ==; In-Reply-To: <87v7v6ek7g.fsf@gmail.com> (message from Visuwesh on Thu, 26 Dec 2024 17:21:15 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297766 Archived-At: > From: Visuwesh > Cc: michael_heerdegen@web.de, 74700@debbugs.gnu.org > Date: Thu, 26 Dec 2024 17:21:15 +0530 > > [வியாழன் டிசம்பர் 26, 2024] Eli Zaretskii wrote: > > >> [...] > >> >> +++ # > >> >> @@ -2089,8 +2089,10 @@ > >> >> `( mouse-face highlight > >> >> help-echo "mouse-1: revert this buffer" > >> >> keymap ,(define-keymap > >> >> - "" #'revert-buffer > >> >> - "" 'follow-link > >> >> + "" (lambda (_) > >> >> + (interactive "@e") > >> >> + (revert-buffer)) > >> >> + "" 'mouse-face > >> > > >> > I don't know how to fix the mouse-1 problem in a sensible way either. > >> > Does anyone? > >> > > >> > (And I think in this version the "e" code in `interactive' isn't > >> > significant - but let's first see if we can improve the behavior even > >> > more.) > >> > >> Indeed, I thought @ had to go with e _always_. > > > > Thanks, so please post a proper patch with a commit log message, so I > > could install it. > > Thanks, patch attached. Thanks, installed on master.