From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: VC commit missing ChangeLog message Date: Wed, 12 Nov 2008 11:17:31 -0600 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <86tzacg8yc.fsf@lifelogs.com> References: <86ej1il3z7.fsf@lifelogs.com> <1226414985.525611.2969.nullmailer@null> <8663mukybp.fsf@lifelogs.com> <200811111658.mABGwYR1004191@mothra.ics.uci.edu> <86myg6hycx.fsf@lifelogs.com> <200811111945.mABJjWvA004946@mothra.ics.uci.edu> <86od0mgcz5.fsf@lifelogs.com> <200811120111.mAC1B6h1005596@mothra.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1226510314 6294 80.91.229.12 (12 Nov 2008 17:18:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Nov 2008 17:18:34 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 12 18:19:33 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L0JMp-00017N-9F for ged-emacs-devel@m.gmane.org; Wed, 12 Nov 2008 18:18:59 +0100 Original-Received: from localhost ([127.0.0.1]:54185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0JLh-0008Mt-8w for ged-emacs-devel@m.gmane.org; Wed, 12 Nov 2008 12:17:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0JLd-0008Mo-LP for emacs-devel@gnu.org; Wed, 12 Nov 2008 12:17:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0JLc-0008Mc-79 for emacs-devel@gnu.org; Wed, 12 Nov 2008 12:17:45 -0500 Original-Received: from [199.232.76.173] (port=41761 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0JLc-0008MZ-2i for emacs-devel@gnu.org; Wed, 12 Nov 2008 12:17:44 -0500 Original-Received: from main.gmane.org ([80.91.229.2]:42103 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L0JLb-0002Ul-Ro for emacs-devel@gnu.org; Wed, 12 Nov 2008 12:17:44 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1L0JLZ-0006FB-3x for emacs-devel@gnu.org; Wed, 12 Nov 2008 17:17:41 +0000 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Nov 2008 17:17:41 +0000 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Nov 2008 17:17:41 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 50 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:g/xMr3HwQQ65IkbGz+pG3Op8Afc= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105606 Archived-At: On Tue, 11 Nov 2008 17:11:06 -0800 (PST) Dan Nicolaescu wrote: DN> If you are interested in improving this area, please also look at one of DN> the TODO items in vc.el: DN> ;; - When vc-next-action calls vc-checkin it could pre-fill the DN> ;; *VC-log* buffer with some obvious items: the list of files that DN> ;; were added, the list of files that were removed. If the diff is DN> ;; available, maybe it could even call something like DN> ;; `diff-add-change-log-entries-other-window' to create a detailed DN> ;; skeleton for the log... DN> ;; I think that should be up to the user, to be done in the hook. The information, diff and files added/removed/affected, exists outside the commit message so putting it inside the message duplicates the information. DN> If you are going to add the ChangeLog entries by default, then why DN> bother with adding the text ? DN> IMO adding text is inconvenient to users: they either have to read DN> it, or they might think they have to delete it so that it does not DN> get checked in. It would be nice to be able to insert text that is DN> not part of the buffer, like in the header line, but that is a DN> single line unfortunately :-( I see your point and agree. How about this patch to just call log-edit-insert-changelog? I call it regardless of the SETUP parameter, but it could follow the erase-buffer call instead. Ted Index: log-edit.el =================================================================== RCS file: /sources/emacs/emacs/lisp/log-edit.el,v retrieving revision 1.51 diff -c -r1.51 log-edit.el *** log-edit.el 6 May 2008 07:57:42 -0000 1.51 --- log-edit.el 12 Nov 2008 17:13:04 -0000 *************** *** 345,350 **** --- 345,351 ---- (if buffer (set (make-local-variable 'log-edit-parent-buffer) parent)) (set (make-local-variable 'log-edit-initial-files) (log-edit-files)) + (log-edit-insert-changelog) (when setup (run-hooks 'log-edit-hook)) (goto-char (point-min)) (push-mark (point-max)) (message "%s" (substitute-command-keys