From: "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
To: help-gnu-emacs-mXXj517/zsQ@public.gmane.org
Subject: Re: Calling Ediff which ignores whitespaces from VC Dir
Date: Fri, 02 Aug 2013 11:11:50 +0200 [thread overview]
Message-ID: <86txj8jw2x.fsf@somewhere.org> (raw)
In-Reply-To: mailman.2315.1375371479.12400.help-gnu-emacs@gnu.org
Stefan Monnier wrote:
>> Debugger entered--Lisp error: (wrong-number-of-arguments (1 . 2) 0)
>
> 0 is the number of args you have provided. (1 . 2) is the min and max
> number of args expected by the function.
>
>> With no certainty, I've tried to copy the parameters of `vc-ediff':
>
>> --8<---------------cut here---------------start------------->8---
>> (defun vc-ediff-ignore-whitespace (historic &optional not-urgent)
>> "Ignore regions that differ in white space & line breaks only."
>> (interactive (list current-prefix-arg t))
>> (let ((ediff-ignore-similar-regions t))
>> (vc-ediff historic not-urgent)))
>
> You could also use (call-interactively 'vc-ediff) instead.
OK, less error-prone (in case arguments to `vc-ediff' would change).
>> call-interactively: Symbol's value as variable is void:
>> ediff-ignore-similar-regions
>
> That's because ediff was (auto)loaded while ediff-ignore-similar-regions
> was let-bound. So at the end of the let, ediff-ignore-similar-regions
> was reset to its previous value (i.e. unbound).
>
> That's a long standing problem. To work around such issues, you want to
> explicitly load ediff before doing the let.
When you say "load ediff", I assume you mean writing a `require' call, right?
That way, it's not loaded multiple times?
OK. Latest version, then:
--8<---------------cut here---------------start------------->8---
(defun vc-ediff-ignore-whitespace (historic &optional not-urgent)
"Ignore regions that differ in white space & line breaks only."
(interactive (list current-prefix-arg t))
(require 'ediff)
(let ((ediff-ignore-similar-regions t))
(call-interactively 'vc-ediff)))
--8<---------------cut here---------------end--------------->8---
Though there is no error anymore, it does not work: "similar regions" are not
skipped as expected.
Something due to the fact that the variable `ediff-ignore-similar-regions' is
a local one? When checking its value in the Ediff control window, I see it's
nil -- which confirms the fact that the `let' is somehow not "applied"
correctly.
Is there a way to work around this?
Best regards,
Seb
--
Sebastien Vauban
next prev parent reply other threads:[~2013-08-02 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 14:28 Calling Ediff which ignores whitespaces from VC Dir Sebastien Vauban
2013-08-01 15:37 ` Stefan Monnier
[not found] ` <mailman.2315.1375371479.12400.help-gnu-emacs@gnu.org>
2013-08-02 9:11 ` Sebastien Vauban [this message]
2013-08-02 14:39 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86txj8jw2x.fsf@somewhere.org \
--to=sva-news-d0wtavr13harg/idocfnwg@public.gmane.org \
--cc=help-gnu-emacs-mXXj517/zsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.