From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#31946: 27.0.50; The NSM should warn about more TLS problems Date: Mon, 26 Aug 2019 19:19:56 +0100 Message-ID: <86tva3rdpv.fsf@gmail.com> References: <87h8647de5.fsf@gnus.org> <86tva4dq8h.fsf@gmail.com> <83k1azgbbi.fsf@gnu.org> <86zhjvrfbp.fsf@gmail.com> <83blwbg5i2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="226015"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) To: 31946@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 26 20:21:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2JcD-000wfA-45 for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 20:21:17 +0200 Original-Received: from localhost ([::1]:56412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2JcB-0003GC-RH for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 14:21:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56999) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2Jc2-0003EZ-1U for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 14:21:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2Jbz-0002zv-Uh for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 14:21:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38387) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2Jby-0002y3-Et for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 14:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2Jby-00080B-8s for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 14:21:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Aug 2019 18:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security fixed X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.156684361330675 (code B ref -1); Mon, 26 Aug 2019 18:21:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Aug 2019 18:20:13 +0000 Original-Received: from localhost ([127.0.0.1]:47208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2JbA-0007yh-Q1 for submit@debbugs.gnu.org; Mon, 26 Aug 2019 14:20:12 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2Jb8-0007yW-SW for submit@debbugs.gnu.org; Mon, 26 Aug 2019 14:20:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56728) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2Jb7-0002wW-HM for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 14:20:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2Jb6-0001tf-Es for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 14:20:09 -0400 Original-Received: from 195-159-176-226.customer.powertech.no ([195.159.176.226]:50664 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i2Jb5-0001nV-NN for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 14:20:08 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1i2Jb1-000vJy-7W for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 20:20:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:zWFY93xfU9ahteUwDo0FUqy1d8M= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165918 Archived-At: On Mon 26 Aug 2019, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Mon, 26 Aug 2019 18:45:14 +0100 >> >> > That's because any memory allocated by GnuTLS cannot be freed by Emacs >> > via 'free' or 'xfree', it needs to be freed by calling 'gnutls_free' >> > (the GnuTLS manual clearly says that, btw). That crashes, because on >> > Windows we use our own implementation of 'free', which uses a >> > different heap. >> >> Agreed, but master built from commit 1071a4f still crashes in the same >> way: > > Can you show a recipe? 1) Delete ~/.emacs.d/network-security.data (to ensure NSM will query the user). 2) Run "emacs -Q" 3) "M-x list-packages", and at the NSM prompt, answer 'a' or 's' or 'd'. >> In Fgnutls_format_certificate, should out_buf be freed after calling >> build_string ? > > I see no problem with that, since build_string copies the data. > >> Removing both xfree(out.data) and xfree(out_buf) from the end of >> that function does give me a running emacs. > > It may run, but it leaks memory. Agreed - it is a data point to explore the problem rather than a solution. AndyM