> Two caveats:
>
> +      (dolist (parameter (window-parameters))
> +        (set-window-parameter nil (car parameter) nil))
>
> Maybe you should remove the 'window-side' and the 'window-atom'
> parameters only - users can assign arbitrary parameters to windows.

If other window parameters are harmless, then only these two could be
removed.

> +        (unless (eq tab-bar-new-tab-choice 'window)
> +          ;; Create a new window to get rid of old window parameters
> +          ;; (e.g. prev/next buffers) of old window.
> +          (split-window) (delete-window)))
>
> Note that this will lose other settings as well like the window's
> dedicated status.  If this is the intended behavior, you should at least
> tell so in the doc-string.

If you mean the case when tab-bar-new-tab-choice is 'window',
then it will lose only 'window-atom' and 'window-side', because
the value 'window' is intended to keep a single window on the tab.

In other cases at this point, all windows were already saved to
window-configuration, so this window is disposable and can be modified
before immediately deleting it.  After saving windows to
window-configuration, the task here is just to create a new window.

So now a new patch with the updated doc-string: