From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#8163: 23.2; Feature request: dabbrev look at filenames or buffer names Date: Thu, 12 May 2022 19:42:09 +0300 Organization: LINKOV.NET Message-ID: <86tu9v3pia.fsf@mail.linkov.net> References: <07CC43C25304A546B995A31E70BF56B50444C0@wcl-exc.wcl.local> <8735him6c3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20398"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 8163@debbugs.gnu.org, Ed Avis To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 12 19:13:51 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npCNp-00059r-QB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 May 2022 19:13:49 +0200 Original-Received: from localhost ([::1]:56964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npCNo-00062p-Cd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 May 2022 13:13:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npCJF-0001Hh-4E for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 13:09:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48262) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npCJE-00026b-PI for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 13:09:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1npCJE-00055B-Ks for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 13:09:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 May 2022 17:09:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8163 X-GNU-PR-Package: emacs Original-Received: via spool by 8163-submit@debbugs.gnu.org id=B8163.165237528719345 (code B ref 8163); Thu, 12 May 2022 17:09:04 +0000 Original-Received: (at 8163) by debbugs.gnu.org; 12 May 2022 17:08:07 +0000 Original-Received: from localhost ([127.0.0.1]:42135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npCIJ-00051w-GG for submit@debbugs.gnu.org; Thu, 12 May 2022 13:08:07 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:37603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npCIE-000510-Fd for 8163@debbugs.gnu.org; Thu, 12 May 2022 13:08:03 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 52FCD24000D; Thu, 12 May 2022 17:07:54 +0000 (UTC) In-Reply-To: <8735him6c3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 10 May 2022 05:09:32 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232079 Archived-At: >> Start emacs and start editing a file called abcdef: >> >> C-x C-f abcdef RET >> >> In that buffer type abcde and then press M-/ to run dabbrev-expand. >> >> Desired result: dabbrev looks at the buffer name (or the name of the >> file it is visiting) and uses that to complete the string to 'abcdef'. >> It could use the names of all open buffers as part of its pool. > > Makes sense to me. I've now added this to Emacs 29. Now dabbrev fails with: Debugger entered--Lisp error: (error "Selecting deleted buffer") dabbrev--find-expansion("dabbr" -1 t) dabbrev-expand(nil) funcall-interactively(dabbrev-expand nil) command-execute(dabbrev-expand) because dabbrev--last-buffer is a killed buffer in dabbrev--find-expansion: (setq dabbrev--last-buffer (pop dabbrev--friend-buffer-list)) (set-buffer dabbrev--last-buffer) I don't see how can it not fail when the temporary buffer "*abbrev-file*" gets added to dabbrev--friend-buffer-list: (setq dabbrev--friend-buffer-list (append dabbrev--friend-buffer-list (list file-name-buffer)))) and then gets deleted afterwards: (when (buffer-live-p file-name-buffer) (kill-buffer file-name-buffer)))))))) So dabbrev--friend-buffer-list always contains '(... #) at the end, and at the next call to dabbrev--last-buffer causes the error.