From: Juri Linkov <juri@linkov.net>
To: Max Brieiev <max.brieiev@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 57813@debbugs.gnu.org
Subject: bug#57813: Icon images are non-functional
Date: Sun, 23 Oct 2022 19:55:52 +0300 [thread overview]
Message-ID: <86tu3u7a3r.fsf@mail.linkov.net> (raw)
In-Reply-To: <86wn94ooqs.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 12 Oct 2022 21:55:55 +0300")
>> It seems in some cases this can cause an overlap between the heading and
>> the image, like on the screenshot:
>
> It's hard to guess whether the outlines are using buttons or margins.
> Probably buttons, because margins are not displayed in *Completions*.
> Actually the same problem exists for both of them. By default the
> button/margin face is inherited, because in most modes inheriting
> fontification from the outline heading lines provides a nicer look,
> but your example demonstrates that in some cases that face needs to be
> overridden. Then there are several variants what face to use instead:
> 1. the default face; 2. the outline faces outline-1, outline-2, ...
> corresponding to the outline level. So it's not clear what to prefer here.
Now refactored the outline button icon functions to support
the face attribute of the icon for margins and buttons.
So if an icon definition is customized to contain
e.g. ':face default':
(define-icon outline-open nil
'((image "outline-open.svg" "outline-open.pbm" :height (0.8 . em)
:face default)
(symbol " ▼ "
:face default))
then it doesn't inherit the outline heading face.
> But there is a simpler way to avoid such a problem: it's possible
> to customize the face 'completions-group-separator' to remove
> the face attribute 'strike-through'. Then you can also use:
> (setq-local outline-minor-mode-highlight 'override)
> that will use the outline faces on the group headings,
> and the button/margin will inherit it.
For better compatibility with different face combinations,
I changed the 'completions-group-separator' face attribute
'strike-through' to 'underline'.
next prev parent reply other threads:[~2022-10-23 16:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 19:40 bug#57813: Icon images are non-functional Juri Linkov
2022-09-15 16:30 ` Juri Linkov
2022-09-15 16:36 ` Juri Linkov
2022-09-15 16:53 ` Eli Zaretskii
2022-09-15 17:35 ` Juri Linkov
2022-09-15 18:32 ` Eli Zaretskii
2022-09-15 19:46 ` Juri Linkov
2022-09-16 16:16 ` Juri Linkov
2022-09-15 19:53 ` Juri Linkov
2022-09-16 5:29 ` Eli Zaretskii
2022-09-16 7:09 ` Juri Linkov
2022-09-17 19:37 ` Juri Linkov
2022-09-18 5:08 ` Eli Zaretskii
2022-09-18 18:46 ` Juri Linkov
2022-09-18 5:17 ` Eli Zaretskii
2022-09-18 19:06 ` Juri Linkov
2022-09-19 12:12 ` Eli Zaretskii
2022-09-19 19:37 ` Juri Linkov
2022-09-20 11:31 ` Eli Zaretskii
2022-09-20 16:12 ` Juri Linkov
2022-09-23 15:48 ` Juri Linkov
2022-09-23 16:26 ` Lars Ingebrigtsen
2022-09-24 17:17 ` Juri Linkov
2022-10-12 14:42 ` Max Brieiev
2022-10-12 18:55 ` Juri Linkov
2022-10-23 16:55 ` Juri Linkov [this message]
2022-10-13 7:51 ` Juri Linkov
2022-10-18 18:14 ` Juri Linkov
2022-10-18 18:35 ` Juri Linkov
2022-10-19 6:44 ` Juri Linkov
2022-10-22 18:38 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86tu3u7a3r.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=57813@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=max.brieiev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.