From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.devel Subject: Re: Patch for reftex.el: master or release branch? Date: Wed, 14 Dec 2022 21:37:02 +0100 Message-ID: <86tu1xhgcx.fsf@gnu.org> References: <867cyuktnw.fsf@gnu.org> <83wn6um7x6.fsf@gnu.org> <875yeexdbe.fsf@gnu.org> <83iliem0mb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7490"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 Cc: Tassilo Horn , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 14 22:14:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5Z5U-0001lJ-JH for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Dec 2022 22:14:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5Z4x-00061W-0m; Wed, 14 Dec 2022 16:14:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Z4v-00061O-1H for emacs-devel@gnu.org; Wed, 14 Dec 2022 16:14:13 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Z4u-0005R8-MI for emacs-devel@gnu.org; Wed, 14 Dec 2022 16:14:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=bKr9TnZ/SlWJynUTpZXBfUQ7oXEwx9iYbKPJMgTIEFA=; b=qOJvZW0OrO97OBLdAHRm 4hikZVzbn2auiiIXsy7vNtnM+7AZo0dL3uxVoFcXqVuKyLtZPSjFTqIek0r3kc5/WDGHwRbwS0eqM fd1f07LMkWdAamgK3Aa7OB4yo44WXfU8BKoAqajMax/nkfvuciQKFqxWeyLX6pUp+No/1QIIx5gqG ZVQJjSGu10OP0r43mUnJfFzdAdHxtl4jGI9q1qeY9cjVohArVu6Kp3E2hYkSDwzAx2mT+fIc5xg+W /u0oqPDO3nL9Wo/r539f+fXUp4BFmTMcgSiMkkP76IfH2tl7CsRAaac2yu04QxCM1g+CAE/3ghm/n gDqVSKYXZrr9+w==; Original-Received: from p5b3263c3.dip0.t-ipconnect.de ([91.50.99.195] helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Z4t-0001aM-Ue; Wed, 14 Dec 2022 16:14:12 -0500 In-Reply-To: <83iliem0mb.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 14 Dec 2022 18:05:48 +0200") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301413 Archived-At: Eli Zaretskii writes: > So if Arash thinks this is safe, it is fine with me to install this on > emacs-29. Thanks. Yes, I think it's safe. It basically uses the same thing done in reftex-parse.el[1] as well. Reg. impact of the current implementation: I consider the impact higher than in the bug report since one effectively can't force RefTeX to ignore a file which is included by \input, \include, \LTXtable etc. by commenting out that macro. RefTeX offers a label in such a file for completion while running LaTeX will throw a warning about unresolved references. I installed the change (commit 622838b957) on emacs-29 branch. Best, Arash Footnotes: [1] http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/textmodes/reftex-parse.el#n276