From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18132@debbugs.gnu.org
Subject: bug#18132: Time for a smarter dired-guess-shell-alist-default? (dired-x.el)
Date: Tue, 28 Nov 2023 19:05:46 +0200 [thread overview]
Message-ID: <86ttp6j8ax.fsf@mail.linkov.net> (raw)
In-Reply-To: <86msuz5cft.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 27 Nov 2023 19:32:54 +0200")
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
> So now pushed to master.
Here is a patch that adds an option to use a system-dependent command
to open a file:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: shell-command-guess-open.patch --]
[-- Type: text/x-diff, Size: 1316 bytes --]
diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index 47e97c96ce1..e945052b571 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -1329,6 +1329,7 @@ shell-command-guess-functions
(choice (function-item shell-command-guess-dired)
(function-item shell-command-guess-mailcap)
(function-item shell-command-guess-xdg)
+ (function-item shell-command-guess-open)
(function :tag "Custom function")))
:group 'dired
:version "30.1")
@@ -1380,6 +1381,29 @@ shell-command-guess-xdg
xdg-mime-apps)))
(append xdg-commands commands)))
+(defcustom shell-command-guess-open
+ (cond
+ ((executable-find "xdg-open")
+ "xdg-open")
+ ((executable-find "run-mailcap")
+ "run-mailcap")
+ ((eq system-type 'ms-dos)
+ "start")
+ ((eq system-type 'cygwin)
+ "cygstart")
+ ((eq system-type 'windows-nt)
+ "open")
+ ((eq system-type 'darwin)
+ "open"))
+ "A shell command to open a file externally."
+ :type 'string
+ :group 'dired
+ :version "30.1")
+
+(defun shell-command-guess-open (commands _files)
+ "Populate COMMANDS by the `open' command."
+ (append (ensure-list shell-command-guess-open) commands))
+
\f
;;; Commands that delete or redisplay part of the dired buffer
next prev parent reply other threads:[~2023-11-28 17:05 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 18:26 bug#18132: Time for a smarter dired-guess-shell-alist-default? (dired-x.el) Reuben Thomas
2014-07-28 18:44 ` bug#18132: Sample code Reuben Thomas
2014-07-29 23:49 ` bug#18132: Time for a smarter dired-guess-shell-alist-default? (dired-x.el) Juri Linkov
2014-07-30 9:12 ` Reuben Thomas
2014-07-30 16:32 ` Juri Linkov
2014-07-30 16:44 ` Reuben Thomas
2014-08-04 23:45 ` Juri Linkov
2014-08-05 9:41 ` Reuben Thomas
2021-10-23 5:25 ` Stefan Kangas
2021-10-23 7:44 ` Eli Zaretskii
2021-10-23 8:16 ` Stefan Kangas
2021-10-23 8:34 ` Eli Zaretskii
2021-10-23 9:48 ` Stefan Kangas
2021-10-23 11:48 ` Eli Zaretskii
2021-10-23 13:06 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 13:20 ` Eli Zaretskii
2021-10-23 13:01 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 13:56 ` Stefan Kangas
2021-10-23 14:03 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 15:45 ` Stefan Kangas
2021-10-23 17:17 ` Gregory Heytings
2021-10-23 20:53 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-24 6:02 ` Eli Zaretskii
2021-10-24 7:56 ` Juri Linkov
2023-11-23 17:49 ` Juri Linkov
2023-11-23 19:40 ` Eli Zaretskii
2023-11-24 7:51 ` Juri Linkov
2023-11-24 14:24 ` Eli Zaretskii
2023-11-25 18:10 ` Juri Linkov
2023-11-26 10:37 ` Eli Zaretskii
2023-11-27 17:32 ` Juri Linkov
2023-11-28 17:05 ` Juri Linkov [this message]
2023-11-28 17:35 ` Eli Zaretskii
2023-11-29 7:09 ` Juri Linkov
2023-11-29 13:07 ` Eli Zaretskii
2023-12-02 17:44 ` Juri Linkov
2023-12-02 18:37 ` Drew Adams
2023-12-03 17:04 ` Juri Linkov
2023-12-03 21:16 ` Drew Adams
2023-12-06 17:28 ` Juri Linkov
2023-12-07 17:33 ` Juri Linkov
2023-12-07 17:48 ` Eli Zaretskii
2023-12-08 7:37 ` Juri Linkov
2023-12-08 8:08 ` Eli Zaretskii
2023-12-09 17:13 ` Juri Linkov
2024-05-22 6:16 ` Juri Linkov
2024-05-22 12:42 ` Eli Zaretskii
2024-05-23 6:19 ` Juri Linkov
2024-05-23 7:16 ` Eli Zaretskii
2024-05-23 17:31 ` Juri Linkov
2024-05-23 18:15 ` Eli Zaretskii
2024-05-24 6:44 ` Juri Linkov
2024-05-24 7:31 ` Eli Zaretskii
2024-05-24 17:56 ` Juri Linkov
2021-10-23 17:57 ` Howard Melman
2021-10-23 18:29 ` Juri Linkov
2021-10-23 19:22 ` bug#18132: [External] : " Drew Adams
2021-10-24 16:35 ` Howard Melman
2021-10-24 19:08 ` Juri Linkov
2021-10-24 5:10 ` Thierry Volpiatto
2014-07-30 3:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ttp6j8ax.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=18132@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.